Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: Source/web/WebPageSerializer.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added alias for LocalFrame downcast Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebPageSerializer.cpp
diff --git a/Source/web/WebPageSerializer.cpp b/Source/web/WebPageSerializer.cpp
index ac543d6b2c368cefdac827f7c9f1d0be2be9777d..ac90aa66b29c6feba404472ff9ebf882a384066d 100644
--- a/Source/web/WebPageSerializer.cpp
+++ b/Source/web/WebPageSerializer.cpp
@@ -113,9 +113,10 @@ void retrieveResourcesForElement(Element* element,
if ((element->hasTagName(HTMLNames::iframeTag) || element->hasTagName(HTMLNames::frameTag)
|| element->hasTagName(HTMLNames::objectTag) || element->hasTagName(HTMLNames::embedTag))
&& element->isFrameOwnerElement()) {
- if (LocalFrame* frame = toHTMLFrameOwnerElement(element)->contentFrame()) {
- if (!visitedFrames->contains(frame))
- framesToVisit->append(frame);
+ Frame* frame = toHTMLFrameOwnerElement(element)->contentFrame();
+ if (frame && frame->isLocalFrame()) {
+ if (!visitedFrames->contains(toLocalFrame(frame)))
+ framesToVisit->append(toLocalFrame(frame));
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698