Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: Source/core/frame/LocalFrame.h

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added alias for LocalFrame downcast Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalFrame.h
diff --git a/Source/core/frame/LocalFrame.h b/Source/core/frame/LocalFrame.h
index 718b91a79451d05bffae4f54b9a1644b19433cba..f34de3d35f47a129dfb8e211a98b6450c6287a76 100644
--- a/Source/core/frame/LocalFrame.h
+++ b/Source/core/frame/LocalFrame.h
@@ -72,9 +72,6 @@ namespace WebCore {
virtual void willDetachFrameHost() OVERRIDE;
virtual void detachFromFrameHost() OVERRIDE;
- void disconnectOwnerElement();
-
- HTMLFrameOwnerElement* ownerElement() const;
virtual void setDOMWindow(PassRefPtr<DOMWindow>) OVERRIDE;
FrameView* view() const;
@@ -214,11 +211,6 @@ namespace WebCore {
return *m_inputMethodController;
}
- inline HTMLFrameOwnerElement* LocalFrame::ownerElement() const
- {
- return m_ownerElement;
- }
-
inline bool LocalFrame::inViewSourceMode() const
{
return m_inViewSourceMode;
@@ -244,4 +236,9 @@ namespace WebCore {
} // namespace WebCore
+// During refactoring, there are some places where we need to do type conversions that
+// will not be needed once all instances of LocalFrame and RemoteFrame are sorted out.
+// At that time this #define will be removed and all the uses of it will need to be corrected.
+#define toLocalFrameTemporary toLocalFrame
eseidel 2014/03/24 16:12:48 I would have just defined the function: LocalFram
kenrb 2014/03/24 16:27:40 The DEFINE_TYPE_CASTS macro ends up creating 4 fun
+
#endif // LocalFrame_h

Powered by Google App Engine
This is Rietveld 408576698