Convert HTMLFrameOwnerElement and FocusController to use Frame.

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 977 matching lines @@
     }
     default:
         if (source->isShadowRoot()) {
             // ShadowRoot cannot disconnect itself from the host node.
             exceptionState.throwDOMException(HierarchyRequestError, "The node provided is a shadow root, which may not be adopted.");
             return nullptr;
         }
 
         if (source->isFrameOwnerElement()) {
             HTMLFrameOwnerElement* frameOwnerElement = toHTMLFrameOwnerElement(source.get());
-            if (frame() && frame()->tree().isDescendantOf(frameOwnerElement->contentFrame())) {
+            // FIXME(kenrb): the toLocalFrame() cast should be removed when the FrameTree supports RemoteFrames.
+            if (frame() && frame()->tree().isDescendantOf(toLocalFrame(frameOwnerElement->contentFrame()))) {

[eseidel, 2014/03/21 19:01:35]

Why not just add the check now?  What would this code do when it's a
RemoteFrame?

[kenrb, 2014/03/21 19:59:31]

It will pass a Frame to the FrameTree rather than a LocalFrame, so no conversion
necessary.

                 exceptionState.throwDOMException(HierarchyRequestError, "The node provided is a frame which contains this document.");
                 return nullptr;
             }
         }
         if (source->parentNode()) {
             source->parentNode()->removeChild(source.get(), exceptionState);
             if (exceptionState.hadException())
                 return nullptr;
         }
     }
@@ skipping 4432 matching lines @@
     if (Element* element = treeScope().adjustedFocusedElement())
         return element;
     return body();
 }
 
 bool Document::hasFocus() const
 {
     Page* page = this->page();
     if (!page)
         return false;
-    if (!page->focusController().isActive() || !page->focusController().isFocused())
+    if (!page->focusController().isActive() || !page->focusController().isFocused() || !page->focusController().focusedFrame()->isLocalFrame())
         return false;
-    if (LocalFrame* focusedFrame = page->focusController().focusedFrame()) {
+    if (LocalFrame* focusedFrame = toLocalFrame(page->focusController().focusedFrame())) {

[eseidel, 2014/03/21 19:01:35]

Does this make sense?  Will the Document be able to talk to the FocusController
like this?

[kenrb, 2014/03/21 19:59:31]

I think so. We haven't started writing any code for the FocusController
refactoring (afaik), so we might need to look at this again later, but right now
I don't see why interactions like this would change.

         if (focusedFrame->tree().isDescendantOf(frame()))
             return true;
     }
     return false;
 }
 
 // FIXME: Remove this code once we have input routing in the browser
 // process. See http://crbug.com/339659.
 void Document::defaultEventHandler(Event* event)
 {
@@ skipping 32 matching lines @@
 }
 
 void Document::invalidateNodeListCaches(const QualifiedName* attrName)
 {
     HashSet<LiveNodeListBase*>::iterator end = m_listsInvalidatedAtDocument.end();
     for (HashSet<LiveNodeListBase*>::iterator it = m_listsInvalidatedAtDocument.begin(); it != end; ++it)
         (*it)->invalidateCache(attrName);
 }
 
 } // namespace WebCore