Convert HTMLFrameOwnerElement and FocusController to use Frame.

Source/web/ContextMenuClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 177 matching lines @@
     HitTestResult r = m_webView->page()->contextMenuController().hitTestResult();
     LocalFrame* selectedFrame = r.innerNodeFrame();
 
     WebContextMenuData data;
     IntPoint mousePoint = selectedFrame->view()->contentsToWindow(r.roundedPointInInnerNodeFrame());
     mousePoint.scale(m_webView->pageScaleFactor(), m_webView->pageScaleFactor());
     data.mousePosition = mousePoint;
 
     // Compute edit flags.
     data.editFlags = WebContextMenuData::CanDoNone;
-    if (m_webView->focusedWebCoreFrame()->editor().canUndo())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canUndo())

[dcheng, 2014/03/17 18:17:44]

Hm... what guarantees that these are always focused? Is it because the only ways
to invoke the context menu require that the frame have focus (right-clicking,
context menu keyboard button)? If so, should we add an assert?

Or is this currently true because of the way WebViewImpl filters out events for
RemoteFrame?

[kenrb, 2014/03/18 20:01:19]

The downcast macro already contains an ASSERT. I think context menu creation
should already be in the correct process.

         data.editFlags |= WebContextMenuData::CanUndo;
-    if (m_webView->focusedWebCoreFrame()->editor().canRedo())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canRedo())
         data.editFlags |= WebContextMenuData::CanRedo;
-    if (m_webView->focusedWebCoreFrame()->editor().canCut())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCut())
         data.editFlags |= WebContextMenuData::CanCut;
-    if (m_webView->focusedWebCoreFrame()->editor().canCopy())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCopy())
         data.editFlags |= WebContextMenuData::CanCopy;
-    if (m_webView->focusedWebCoreFrame()->editor().canPaste())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canPaste())
         data.editFlags |= WebContextMenuData::CanPaste;
-    if (m_webView->focusedWebCoreFrame()->editor().canDelete())
+    if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canDelete())
         data.editFlags |= WebContextMenuData::CanDelete;
     // We can always select all...
     data.editFlags |= WebContextMenuData::CanSelectAll;
     data.editFlags |= WebContextMenuData::CanTranslate;
 
     // Links, Images, Media tags, and Image/Media-Links take preference over
     // all else.
     data.linkURL = r.absoluteLinkURL();
 
     if (!r.absoluteImageURL().isEmpty()) {
@@ skipping 97 matching lines @@
             if (marker.description().length()) {
                 Vector<String> suggestions;
                 marker.description().split('\n', suggestions);
                 data.dictionarySuggestions = suggestions;
             } else if (m_webView->spellCheckClient()) {
                 int misspelledOffset, misspelledLength;
                 m_webView->spellCheckClient()->spellCheck(data.misspelledWord, misspelledOffset, misspelledLength, &data.dictionarySuggestions);
             }
         } else {
             data.isSpellCheckingEnabled =
-                m_webView->focusedWebCoreFrame()->spellChecker().isContinuousSpellCheckingEnabled();
+                toLocalFrame(m_webView->focusedWebCoreFrame())->spellChecker().isContinuousSpellCheckingEnabled();
             // Spellchecking might be enabled for the field, but could be disabled on the node.
-            if (m_webView->focusedWebCoreFrame()->spellChecker().isSpellCheckingEnabledInFocusedNode()) {
+            if (toLocalFrame(m_webView->focusedWebCoreFrame())->spellChecker().isSpellCheckingEnabledInFocusedNode()) {
                 data.misspelledWord = selectMisspelledWord(selectedFrame);
                 if (m_webView->spellCheckClient()) {
                     int misspelledOffset, misspelledLength;
                     m_webView->spellCheckClient()->spellCheck(
                         data.misspelledWord, misspelledOffset, misspelledLength,
                         &data.dictionarySuggestions);
                     if (!misspelledLength)
                         data.misspelledWord.reset();
                 }
             }
@@ skipping 74 matching lines @@
         outputItems[i] = subItems[i];
     subMenuItems.swap(outputItems);
 }
 
 void ContextMenuClientImpl::populateCustomMenuItems(const WebCore::ContextMenu* defaultMenu, WebContextMenuData* data)
 {
     populateSubMenuItems(defaultMenu->items(), data->customItems);
 }
 
 } // namespace blink