Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: Source/bindings/v8/BindingSecurity.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improved downcast checking. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 return true; 73 return true;
74 74
75 if (reportingOption == ReportSecurityError && targetDocument->domWindow()) { 75 if (reportingOption == ReportSecurityError && targetDocument->domWindow()) {
76 if (LocalFrame* frame = targetDocument->frame()) 76 if (LocalFrame* frame = targetDocument->frame())
77 frame->domWindow()->printErrorMessage(targetDocument->domWindow()->c rossDomainAccessErrorMessage(callingWindow)); 77 frame->domWindow()->printErrorMessage(targetDocument->domWindow()->c rossDomainAccessErrorMessage(callingWindow));
78 } 78 }
79 79
80 return false; 80 return false;
81 } 81 }
82 82
83 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, LocalFrame* target, SecurityReportingOption reportingOption) 83 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* targ et, SecurityReportingOption reportingOption)
84 { 84 {
85 return target && canAccessDocument(isolate, target->document(), reportingOpt ion); 85 if (!target->isLocalFrame())
86 return false;
87 return target && canAccessDocument(isolate, toLocalFrame(target)->document() , reportingOption);
86 } 88 }
87 89
88 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, LocalFrame* target, ExceptionState& exceptionState) 90 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* targ et, ExceptionState& exceptionState)
89 { 91 {
90 return target && canAccessDocument(isolate, target->document(), exceptionSta te); 92 if (!target->isLocalFrame())
93 return false;
94 return target && canAccessDocument(isolate, toLocalFrame(target)->document() , exceptionState);
91 } 95 }
92 96
93 bool BindingSecurity::shouldAllowAccessToNode(v8::Isolate* isolate, Node* target , ExceptionState& exceptionState) 97 bool BindingSecurity::shouldAllowAccessToNode(v8::Isolate* isolate, Node* target , ExceptionState& exceptionState)
94 { 98 {
95 return target && canAccessDocument(isolate, &target->document(), exceptionSt ate); 99 return target && canAccessDocument(isolate, &target->document(), exceptionSt ate);
96 } 100 }
97 101
98 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698