Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895693002: [Findit] Add a new UI page for compile failures. (Closed)

Created:
4 years, 8 months ago by stgao
Modified:
4 years, 8 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -28 lines) Patch
M appengine/findit/handlers/build_failure.py View 3 chunks +92 lines, -28 lines 0 comments Download
M appengine/findit/handlers/test/build_failure_test.py View 2 chunks +76 lines, -0 lines 0 comments Download
A appengine/findit/templates/waterfall/compile_failure.html View 1 chunk +338 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
stgao
Hey Chan & Jeff, I'd do a TBR for now, and follow up with comments ...
4 years, 8 months ago (2016-04-18 06:33:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895693002/1
4 years, 8 months ago (2016-04-18 06:34:06 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 06:38:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/8d6b9b142a8fb3b142120dca41505...

Powered by Google App Engine
This is Rietveld 408576698