Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1895673002: X87: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Add relocatable pointer constants for wasm memory references. port 52148c41c948f4e70778de758fb1a0ae118cecc2 (r35407) original commit message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. BUG= Committed: https://crrev.com/8d20dfaf675fb2446eb2e39e2662b2336dd5eb20 Cr-Commit-Position: refs/heads/master@{#35556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-17 15:34:05 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-17 16:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895673002/1
4 years, 8 months ago (2016-04-18 02:30:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 02:47:11 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 02:47:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d20dfaf675fb2446eb2e39e2662b2336dd5eb20
Cr-Commit-Position: refs/heads/master@{#35556}

Powered by Google App Engine
This is Rietveld 408576698