Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1895643002: Revert of [Atomics] Remove Atomics code stubs; use TF ops (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Atomics] Remove Atomics code stubs; use TF ops (patchset #6 id:100001 of https://codereview.chromium.org/1891033002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/6121 Original issue's description: > [Atomics] Remove Atomics code stubs; use TF ops > > This is a much cleaner solution, which won't require nearly as much > architecture-specific code. Thanks bmeurer@! > > BUG=v8:4614 > LOG=y > R=bmeurer@chromium.org,jarin@chromium.org > > Committed: https://crrev.com/6ff5881b1def45b35384572f61327e42563a89c3 > Cr-Commit-Position: refs/heads/master@{#35547} TBR=bmeurer@chromium.org,jarin@chromium.org,rodolph.perfetta@gmail.com,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Committed: https://crrev.com/df19616f370a9fc6b7107714aa308e96291665f5 Cr-Commit-Position: refs/heads/master@{#35548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -293 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +161 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +139 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 4 chunks +16 lines, -64 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +1 line, -34 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +170 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +176 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +164 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Atomics] Remove Atomics code stubs; use TF ops
4 years, 8 months ago (2016-04-16 13:11:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895643002/1
4 years, 8 months ago (2016-04-16 13:11:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 13:11:44 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 13:13:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df19616f370a9fc6b7107714aa308e96291665f5
Cr-Commit-Position: refs/heads/master@{#35548}

Powered by Google App Engine
This is Rietveld 408576698