Use '--source-map' and '--out' options to support source maps from non-commandline.

Use '--source-map' and '--out' options to support source maps from non-commandline.

BUG= http://dartbug.com/17259
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33424

[floitsch, 2014-03-07 10:27:24]

LGTM.

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1536:
assembledCode +=
It seems more efficient if we don't have to create a new string:

String sourceMapTags = "";
if (generateSourceMap) {
  outputSourceMap(...);
  sourceMapTags = generateSourceMapTag(...);
}
compiler.outputProvider('', 'js')
    ..add(assembledCode);
    ..add(sourceMapTags);
    ..close();

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1567:
// TODO(http://dartbug.com/11914): Remove @ line.
I just tried with Chrome beta, and at least there it is already fixed. I'm not
sure of Chrome stable, but I wouldn't be surprised if we could close 11914 and
remove the line now.

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1665:
String buildSourceMap(CodeBuffer buffer,
If buildSourceMap is not used anywhere else I would inline it.

https://codereview.chromium.org/189563004/diff/1/tests/compiler/dart2js/sourc...
File tests/compiler/dart2js/source_map_test.dart (right):

https://codereview.chromium.org/189563004/diff/1/tests/compiler/dart2js/sourc...
tests/compiler/dart2js/source_map_test.dart:46: asyncTest(() =>
compiler.runCompiler(Uri.parse('memory:/main.dart')).then((_) {
long line.

[Johnni Winther, 2014-03-07 12:38:48]

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1536:
assembledCode +=
On 2014/03/07 10:27:24, floitsch wrote:
> It seems more efficient if we don't have to create a new string:
> 
> String sourceMapTags = "";
> if (generateSourceMap) {
>   outputSourceMap(...);
>   sourceMapTags = generateSourceMapTag(...);
> }
> compiler.outputProvider('', 'js')
>     ..add(assembledCode);
>     ..add(sourceMapTags);
>     ..close();

Done.

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1567:
// TODO(http://dartbug.com/11914): Remove @ line.
On 2014/03/07 10:27:24, floitsch wrote:
> I just tried with Chrome beta, and at least there it is already fixed. I'm not
> sure of Chrome stable, but I wouldn't be surprised if we could close 11914 and
> remove the line now.

Will do it in a separate CL.

https://codereview.chromium.org/189563004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1665:
String buildSourceMap(CodeBuffer buffer,
On 2014/03/07 10:27:24, floitsch wrote:
> If buildSourceMap is not used anywhere else I would inline it.

Done.

https://codereview.chromium.org/189563004/diff/1/tests/compiler/dart2js/sourc...
File tests/compiler/dart2js/source_map_test.dart (right):

https://codereview.chromium.org/189563004/diff/1/tests/compiler/dart2js/sourc...
tests/compiler/dart2js/source_map_test.dart:46: asyncTest(() =>
compiler.runCompiler(Uri.parse('memory:/main.dart')).then((_) {
On 2014/03/07 10:27:24, floitsch wrote:
> long line.

Done.

[Johnni Winther, 2014-03-07 12:42:13]

Committed patchset #1 manually as r33424 (presubmit successful).