Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: src/globals.h

Issue 1895603002: [esnext] prototype runtime implementation for async functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@AsyncFunction
Patch Set: update bytecode expectations (CallRuntime.golden) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/js/harmony-async-await.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index 777f4297cb903fe950a76f8ccf8087fefb1cf56c..17572b332191029c7fe7b997b163769e28ae05f3 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -970,7 +970,8 @@ enum FunctionKind {
kClassConstructor =
kBaseConstructor | kSubclassConstructor | kDefaultConstructor,
kAsyncArrowFunction = kArrowFunction | kAsyncFunction,
- kAsyncConciseMethod = kAsyncFunction | kConciseMethod
+ kAsyncConciseMethod = kAsyncFunction | kConciseMethod,
+ kArrowGeneratorFunction = kGeneratorFunction | kArrowFunction
};
inline bool IsValidFunctionKind(FunctionKind kind) {
@@ -988,7 +989,8 @@ inline bool IsValidFunctionKind(FunctionKind kind) {
kind == FunctionKind::kSubclassConstructor ||
kind == FunctionKind::kAsyncFunction ||
kind == FunctionKind::kAsyncArrowFunction ||
- kind == FunctionKind::kAsyncConciseMethod;
+ kind == FunctionKind::kAsyncConciseMethod ||
+ kind == FunctionKind::kArrowGeneratorFunction;
Dan Ehrenberg 2016/05/09 23:02:54 Huh? What's this? I don't think we have syntax for
caitp (gmail) 2016/05/10 00:34:58 beats me, i thought it was added in a rebase, i do
}
@@ -1058,6 +1060,7 @@ inline bool IsConstructable(FunctionKind kind, LanguageMode mode) {
if (IsConciseMethod(kind)) return false;
if (IsArrowFunction(kind)) return false;
if (IsGeneratorFunction(kind)) return false;
+ if (IsAsyncFunction(kind)) return false;
return true;
}
« no previous file with comments | « src/factory.cc ('k') | src/js/harmony-async-await.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698