Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: src/frames.cc

Issue 1895603002: [esnext] prototype runtime implementation for async functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@AsyncFunction
Patch Set: Try new strategy (Option C) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 6f5176261b3881565bf5b8631c8bfd82deadb5d6..d81bbb784abc5f9915e5c50f07174e12fee88b46 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -863,6 +863,14 @@ void JavaScriptFrame::GetFunctions(List<JSFunction*>* functions) const {
void JavaScriptFrame::Summarize(List<FrameSummary>* functions) const {
DCHECK(functions->length() == 0);
Code* code = LookupCode();
+
+ // TODO(caitp): these builtins cause crashes here --- that's not good!
caitp (gmail) 2016/04/26 22:01:30 unfortunately still needed in Option C, for reason
+ // Should probably be a better way to keep functions from being included in
+ // stack trace.
+ if (code == *function()->GetIsolate()->builtins()->AsyncFunctionNext() ||
+ code == *function()->GetIsolate()->builtins()->AsyncFunctionThrow())
+ return;
+
int offset = static_cast<int>(pc() - code->instruction_start());
AbstractCode* abstract_code = AbstractCode::cast(code);
FrameSummary summary(receiver(), function(), abstract_code, offset,

Powered by Google App Engine
This is Rietveld 408576698