[esnext] prototype runtime implementation for async functions

src/factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/factory.h"
 
 #include "src/allocation-site-scopes.h"
 #include "src/base/bits.h"
 #include "src/bootstrapper.h"
 #include "src/conversions.h"
@@ skipping 1209 matching lines @@
   Handle<SharedFunctionInfo> info =
       NewSharedFunctionInfo(name, code, map->is_constructor());
   DCHECK(is_sloppy(info->language_mode()));
   DCHECK(!map->IsUndefined());
   DCHECK(
       map.is_identical_to(isolate()->sloppy_function_map()) ||
       map.is_identical_to(isolate()->sloppy_function_without_prototype_map()) ||
       map.is_identical_to(
           isolate()->sloppy_function_with_readonly_prototype_map()) ||
       map.is_identical_to(isolate()->strict_function_map()) ||
+      map.is_identical_to(isolate()->strict_function_without_prototype_map()) ||

[Dan Ehrenberg, 2016/05/04 22:52:36]

Why do we suddenly need this now, but we didn't need it for concise methods?

[caitp (gmail), 2016/05/06 18:45:26]

I have no idea --- but I'm pretty sure it is a mistake to omit it from here ---
because NewFunctionWithoutPrototype explicitly uses this map --- so it was just
broken before in debug builds if the function was strict.

Could split that out into a separate patch with a unit test or something, I
guess? But since it's a one liner I don't think it matters a lot

[Dan Ehrenberg, 2016/05/09 23:02:54]

Well, if it fixes a previous bug, then at least checking in tests for that bug
together with this patch would be a good thing to do. Splitting it into a
separate patch would be optimal still.

       // TODO(titzer): wasm_function_map() could be undefined here. ugly.
       (*map == context->get(Context::WASM_FUNCTION_MAP_INDEX)) ||
       map.is_identical_to(isolate()->proxy_function_map()));
   return NewFunction(map, info, context);
 }
 
 
 Handle<JSFunction> Factory::NewFunction(Handle<String> name) {
   return NewFunction(
       isolate()->sloppy_function_map(), name, MaybeHandle<Code>());
@@ skipping 413 matching lines @@
     }
   }
 
   array->set_elements(*elms);
   array->set_length(Smi::FromInt(length));
 }
 
 
 Handle<JSGeneratorObject> Factory::NewJSGeneratorObject(
     Handle<JSFunction> function) {
-  DCHECK(function->shared()->is_generator());
+  DCHECK(function->shared()->is_generator() || function->shared()->is_async());
   JSFunction::EnsureHasInitialMap(function);
   Handle<Map> map(function->initial_map());
   DCHECK_EQ(JS_GENERATOR_OBJECT_TYPE, map->instance_type());
   CALL_HEAP_FUNCTION(
       isolate(),
       isolate()->heap()->AllocateJSObjectFromMap(*map),
       JSGeneratorObject);
 }
 
 
@@ skipping 385 matching lines @@
   DCHECK(IsValidFunctionKind(kind));
   Handle<SharedFunctionInfo> shared = NewSharedFunctionInfo(
       name, code, IsConstructable(kind, scope_info->language_mode()));
   shared->set_scope_info(*scope_info);
   shared->set_kind(kind);
   shared->set_num_literals(number_of_literals);
   if (IsGeneratorFunction(kind)) {
     shared->set_instance_class_name(isolate()->heap()->Generator_string());
     shared->DisableOptimization(kGenerator);
   }
+  if (IsAsyncFunction(kind)) {
+    shared->DisableOptimization(kGenerator);
+  }

[Dan Ehrenberg, 2016/05/04 22:52:36]

Nit: Any way you could merge this with the above DisableOptimization call, since
they're for the same reason and will both need to be changed in the near future?

   return shared;
 }
 
 
 Handle<JSMessageObject> Factory::NewJSMessageObject(
     MessageTemplate::Template message, Handle<Object> argument,
     int start_position, int end_position, Handle<Object> script,
     Handle<Object> stack_frames) {
   Handle<Map> map = message_object_map();
   Handle<JSMessageObject> message_obj = New<JSMessageObject>(map, NEW_SPACE);
@@ skipping 292 matching lines @@
 }
 
 
 Handle<Object> Factory::ToBoolean(bool value) {
   return value ? true_value() : false_value();
 }
 
 
 }  // namespace internal
 }  // namespace v8