Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/builtins.cc

Issue 1895603002: [esnext] prototype runtime implementation for async functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@AsyncFunction
Patch Set: majorly improve stack traces, get rid of self-spawning behaviour, create inner generator function Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins.h" 5 #include "src/builtins.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/api-natives.h" 9 #include "src/api-natives.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 2308 matching lines...) Expand 10 before | Expand all | Expand 10 after
2319 void Builtins::Generate_MathTrunc(compiler::CodeStubAssembler* assembler) { 2319 void Builtins::Generate_MathTrunc(compiler::CodeStubAssembler* assembler) {
2320 Generate_MathRoundingOperation(assembler, 2320 Generate_MathRoundingOperation(assembler,
2321 &compiler::CodeStubAssembler::Float64Trunc); 2321 &compiler::CodeStubAssembler::Float64Trunc);
2322 } 2322 }
2323 2323
2324 // ----------------------------------------------------------------------------- 2324 // -----------------------------------------------------------------------------
2325 // ES6 section 25.3 Generator Objects 2325 // ES6 section 25.3 Generator Objects
2326 2326
2327 namespace { 2327 namespace {
2328 2328
2329 enum class ResumeType { Generator, Async };
2330
2329 void Generate_GeneratorPrototypeResume( 2331 void Generate_GeneratorPrototypeResume(
2330 compiler::CodeStubAssembler* assembler, 2332 compiler::CodeStubAssembler* assembler,
2331 JSGeneratorObject::ResumeMode resume_mode, char const* const method_name) { 2333 JSGeneratorObject::ResumeMode resume_mode, char const* const method_name,
2334 ResumeType type) {
2332 typedef compiler::CodeStubAssembler::Label Label; 2335 typedef compiler::CodeStubAssembler::Label Label;
2333 typedef compiler::Node Node; 2336 typedef compiler::Node Node;
2334 2337
2335 Node* receiver = assembler->Parameter(0); 2338 Node* receiver = assembler->Parameter(0);
2336 Node* value = assembler->Parameter(1); 2339 Node* value = assembler->Parameter(1);
2337 Node* context = assembler->Parameter(4); 2340 Node* context = assembler->Parameter(4);
2338 Node* zero = assembler->SmiConstant(Smi::FromInt(0)); 2341 Node* zero = assembler->SmiConstant(Smi::FromInt(0));
2339 2342
2340 // Check if the {receiver} is actually a JSGeneratorObject. 2343 // Check if the {receiver} is actually a JSGeneratorObject.
2341 Label if_receiverisincompatible(assembler, Label::kDeferred); 2344 Label if_receiverisincompatible(assembler, Label::kDeferred);
2342 assembler->GotoIf(assembler->WordIsSmi(receiver), &if_receiverisincompatible); 2345 if (type == ResumeType::Generator || FLAG_debug_code) {
2343 Node* receiver_instance_type = assembler->LoadInstanceType(receiver); 2346 assembler->GotoIf(assembler->WordIsSmi(receiver),
2344 assembler->GotoUnless(assembler->Word32Equal( 2347 &if_receiverisincompatible);
2345 receiver_instance_type, 2348 Node* receiver_instance_type = assembler->LoadInstanceType(receiver);
2346 assembler->Int32Constant(JS_GENERATOR_OBJECT_TYPE)), 2349 assembler->GotoUnless(assembler->Word32Equal(receiver_instance_type,
2347 &if_receiverisincompatible); 2350 assembler->Int32Constant(
2351 JS_GENERATOR_OBJECT_TYPE)),
2352 &if_receiverisincompatible);
2353 }
2348 2354
2349 // Check if the {receiver} is running or already closed. 2355 // Check if the {receiver} is running or already closed.
2350 Node* receiver_continuation = assembler->LoadObjectField(
2351 receiver, JSGeneratorObject::kContinuationOffset);
2352 Label if_receiverisclosed(assembler, Label::kDeferred), 2356 Label if_receiverisclosed(assembler, Label::kDeferred),
2353 if_receiverisrunning(assembler, Label::kDeferred); 2357 if_receiverisrunning(assembler, Label::kDeferred);
2354 assembler->GotoIf(assembler->SmiEqual(receiver_continuation, zero), 2358 if (type == ResumeType::Generator || FLAG_debug_code) {
2355 &if_receiverisclosed); 2359 Node* receiver_continuation = assembler->LoadObjectField(
2356 assembler->GotoIf(assembler->SmiLessThan(receiver_continuation, zero), 2360 receiver, JSGeneratorObject::kContinuationOffset);
2357 &if_receiverisrunning); 2361 assembler->GotoIf(assembler->SmiEqual(receiver_continuation, zero),
2362 &if_receiverisclosed);
2363 assembler->GotoIf(assembler->SmiLessThan(receiver_continuation, zero),
2364 &if_receiverisrunning);
2365 }
2358 2366
2359 // Resume the {receiver} using our trampoline. 2367 // Resume the {receiver} using our trampoline.
2360 Node* result = assembler->CallStub( 2368 Node* result = assembler->CallStub(
2361 CodeFactory::ResumeGenerator(assembler->isolate()), context, value, 2369 CodeFactory::ResumeGenerator(assembler->isolate()), context, value,
2362 receiver, assembler->SmiConstant(Smi::FromInt(resume_mode))); 2370 receiver, assembler->SmiConstant(Smi::FromInt(resume_mode)));
2363 assembler->Return(result); 2371 assembler->Return(result);
2364 2372
2365 assembler->Bind(&if_receiverisincompatible); 2373 assembler->Bind(&if_receiverisincompatible);
2366 { 2374 if (type == ResumeType::Generator || FLAG_debug_code) {
2367 // The {receiver} is not a valid JSGeneratorObject. 2375 // The {receiver} is not a valid JSGeneratorObject.
2368 Node* result = assembler->CallRuntime( 2376 Node* result = assembler->CallRuntime(
2369 Runtime::kThrowIncompatibleMethodReceiver, context, 2377 Runtime::kThrowIncompatibleMethodReceiver, context,
2370 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked( 2378 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked(
2371 method_name, TENURED)), 2379 method_name, TENURED)),
2372 receiver); 2380 receiver);
2373 assembler->Return(result); // Never reached. 2381 assembler->Return(result); // Never reached.
2374 } 2382 }
2375 2383
2376 assembler->Bind(&if_receiverisclosed); 2384 if (type == ResumeType::Generator || FLAG_debug_code) {
2377 { 2385 assembler->Bind(&if_receiverisclosed);
2378 // The {receiver} is closed already. 2386 // The {receiver} is closed already.
2379 Node* result = nullptr; 2387 Node* result = nullptr;
2380 switch (resume_mode) { 2388 switch (resume_mode) {
2381 case JSGeneratorObject::kNext: 2389 case JSGeneratorObject::kNext:
2382 result = assembler->CallRuntime(Runtime::kCreateIterResultObject, 2390 result = assembler->CallRuntime(Runtime::kCreateIterResultObject,
2383 context, assembler->UndefinedConstant(), 2391 context, assembler->UndefinedConstant(),
2384 assembler->BooleanConstant(true)); 2392 assembler->BooleanConstant(true));
2385 break; 2393 break;
2386 case JSGeneratorObject::kReturn: 2394 case JSGeneratorObject::kReturn:
2387 result = 2395 result =
2388 assembler->CallRuntime(Runtime::kCreateIterResultObject, context, 2396 assembler->CallRuntime(Runtime::kCreateIterResultObject, context,
2389 value, assembler->BooleanConstant(true)); 2397 value, assembler->BooleanConstant(true));
2390 break; 2398 break;
2391 case JSGeneratorObject::kThrow: 2399 case JSGeneratorObject::kThrow:
2392 result = assembler->CallRuntime(Runtime::kThrow, context, value); 2400 result = assembler->CallRuntime(Runtime::kThrow, context, value);
2393 break; 2401 break;
2394 } 2402 }
2395 assembler->Return(result); 2403 assembler->Return(result);
2396 } 2404 }
2397 2405
2398 assembler->Bind(&if_receiverisrunning); 2406 if (type == ResumeType::Generator || FLAG_debug_code) {
2399 { 2407 assembler->Bind(&if_receiverisrunning);
2400 Node* result = 2408 Node* result =
2401 assembler->CallRuntime(Runtime::kThrowGeneratorRunning, context); 2409 assembler->CallRuntime(Runtime::kThrowGeneratorRunning, context);
2402 assembler->Return(result); // Never reached. 2410 assembler->Return(result); // Never reached.
2403 } 2411 }
2404 } 2412 }
2405 2413
2406 } // namespace 2414 } // namespace
2407 2415
2408 // ES6 section 25.3.1.2 Generator.prototype.next ( value ) 2416 // ES6 section 25.3.1.2 Generator.prototype.next ( value )
2409 void Builtins::Generate_GeneratorPrototypeNext( 2417 void Builtins::Generate_GeneratorPrototypeNext(
2410 compiler::CodeStubAssembler* assembler) { 2418 compiler::CodeStubAssembler* assembler) {
2411 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext, 2419 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext,
2412 "[Generator].prototype.next"); 2420 "[Generator].prototype.next",
2421 ResumeType::Generator);
2413 } 2422 }
2414 2423
2415 // ES6 section 25.3.1.3 Generator.prototype.return ( value ) 2424 // ES6 section 25.3.1.3 Generator.prototype.return ( value )
2416 void Builtins::Generate_GeneratorPrototypeReturn( 2425 void Builtins::Generate_GeneratorPrototypeReturn(
2417 compiler::CodeStubAssembler* assembler) { 2426 compiler::CodeStubAssembler* assembler) {
2418 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kReturn, 2427 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kReturn,
2419 "[Generator].prototype.return"); 2428 "[Generator].prototype.return",
2429 ResumeType::Generator);
2420 } 2430 }
2421 2431
2422 // ES6 section 25.3.1.4 Generator.prototype.throw ( exception ) 2432 // ES6 section 25.3.1.4 Generator.prototype.throw ( exception )
2423 void Builtins::Generate_GeneratorPrototypeThrow( 2433 void Builtins::Generate_GeneratorPrototypeThrow(
2424 compiler::CodeStubAssembler* assembler) { 2434 compiler::CodeStubAssembler* assembler) {
2425 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow, 2435 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow,
2426 "[Generator].prototype.throw"); 2436 "[Generator].prototype.throw",
2437 ResumeType::Generator);
2438 }
2439
2440 void Builtins::Generate_AsyncFunctionNext(
2441 compiler::CodeStubAssembler* assembler) {
2442 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext,
2443 "[AsyncFunction].next", ResumeType::Async);
2444 }
2445
2446 void Builtins::Generate_AsyncFunctionThrow(
2447 compiler::CodeStubAssembler* assembler) {
2448 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow,
2449 "[AsyncFunction].throw", ResumeType::Async);
2427 } 2450 }
2428 2451
2429 // ----------------------------------------------------------------------------- 2452 // -----------------------------------------------------------------------------
2430 // ES6 section 26.1 The Reflect Object 2453 // ES6 section 26.1 The Reflect Object
2431 2454
2432 // ES6 section 26.1.3 Reflect.defineProperty 2455 // ES6 section 26.1.3 Reflect.defineProperty
2433 BUILTIN(ReflectDefineProperty) { 2456 BUILTIN(ReflectDefineProperty) {
2434 HandleScope scope(isolate); 2457 HandleScope scope(isolate);
2435 DCHECK_EQ(4, args.length()); 2458 DCHECK_EQ(4, args.length());
2436 Handle<Object> target = args.at<Object>(1); 2459 Handle<Object> target = args.at<Object>(1);
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
5311 BUILTIN_LIST_T(DEFINE_BUILTIN_ACCESSOR_T) 5334 BUILTIN_LIST_T(DEFINE_BUILTIN_ACCESSOR_T)
5312 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 5335 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
5313 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 5336 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
5314 #undef DEFINE_BUILTIN_ACCESSOR_C 5337 #undef DEFINE_BUILTIN_ACCESSOR_C
5315 #undef DEFINE_BUILTIN_ACCESSOR_A 5338 #undef DEFINE_BUILTIN_ACCESSOR_A
5316 #undef DEFINE_BUILTIN_ACCESSOR_T 5339 #undef DEFINE_BUILTIN_ACCESSOR_T
5317 #undef DEFINE_BUILTIN_ACCESSOR_H 5340 #undef DEFINE_BUILTIN_ACCESSOR_H
5318 5341
5319 } // namespace internal 5342 } // namespace internal
5320 } // namespace v8 5343 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/code-stubs.h » ('j') | src/parsing/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698