Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/builtins.cc

Issue 1895603002: [esnext] prototype runtime implementation for async functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@AsyncFunction
Patch Set: Partially fix `throw` completions (resumption works, but no resumption doesn't) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.h ('k') | src/compiler.cc » ('j') | src/contexts.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins.h" 5 #include "src/builtins.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/api-natives.h" 9 #include "src/api-natives.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 2308 matching lines...) Expand 10 before | Expand all | Expand 10 after
2319 void Builtins::Generate_MathTrunc(compiler::CodeStubAssembler* assembler) { 2319 void Builtins::Generate_MathTrunc(compiler::CodeStubAssembler* assembler) {
2320 Generate_MathRoundingOperation(assembler, 2320 Generate_MathRoundingOperation(assembler,
2321 &compiler::CodeStubAssembler::Float64Trunc); 2321 &compiler::CodeStubAssembler::Float64Trunc);
2322 } 2322 }
2323 2323
2324 // ----------------------------------------------------------------------------- 2324 // -----------------------------------------------------------------------------
2325 // ES6 section 25.3 Generator Objects 2325 // ES6 section 25.3 Generator Objects
2326 2326
2327 namespace { 2327 namespace {
2328 2328
2329 enum class ResumeType { Generator, Async };
2330
2329 void Generate_GeneratorPrototypeResume( 2331 void Generate_GeneratorPrototypeResume(
2330 compiler::CodeStubAssembler* assembler, 2332 compiler::CodeStubAssembler* assembler,
2331 JSGeneratorObject::ResumeMode resume_mode, char const* const method_name) { 2333 JSGeneratorObject::ResumeMode resume_mode, char const* const method_name,
caitp (gmail) 2016/04/16 18:20:20 None of these changes are really needed, admittedl
2334 ResumeType type) {
2332 typedef compiler::CodeStubAssembler::Label Label; 2335 typedef compiler::CodeStubAssembler::Label Label;
2333 typedef compiler::Node Node; 2336 typedef compiler::Node Node;
2334 2337
2335 Node* receiver = assembler->Parameter(0); 2338 Node* receiver = nullptr;
2336 Node* value = assembler->Parameter(1); 2339 Node* value = nullptr;
2337 Node* context = assembler->Parameter(4); 2340 Node* context = nullptr;
2338 Node* zero = assembler->SmiConstant(Smi::FromInt(0)); 2341 Node* zero = assembler->SmiConstant(Smi::FromInt(0));
2339 2342
2343 switch (type) {
2344 case ResumeType::Generator:
2345 receiver = assembler->Parameter(0);
2346 value = assembler->Parameter(1);
2347 context = assembler->Parameter(4);
2348 break;
2349 case ResumeType::Async:
2350 receiver = assembler->Parameter(1);
2351 value = assembler->Parameter(2);
2352 context = assembler->Parameter(5);
2353 break;
2354 }
2355
2340 // Check if the {receiver} is actually a JSGeneratorObject. 2356 // Check if the {receiver} is actually a JSGeneratorObject.
2341 Label if_receiverisincompatible(assembler, Label::kDeferred); 2357 Label if_receiverisincompatible(assembler, Label::kDeferred);
2342 assembler->GotoIf(assembler->WordIsSmi(receiver), &if_receiverisincompatible); 2358 if (type == ResumeType::Generator || FLAG_debug_code) {
2343 Node* receiver_instance_type = assembler->LoadInstanceType(receiver); 2359 assembler->GotoIf(assembler->WordIsSmi(receiver),
2344 assembler->GotoUnless(assembler->Word32Equal( 2360 &if_receiverisincompatible);
2345 receiver_instance_type, 2361 Node* receiver_instance_type = assembler->LoadInstanceType(receiver);
2346 assembler->Int32Constant(JS_GENERATOR_OBJECT_TYPE)), 2362 assembler->GotoUnless(assembler->Word32Equal(receiver_instance_type,
2347 &if_receiverisincompatible); 2363 assembler->Int32Constant(
2364 JS_GENERATOR_OBJECT_TYPE)),
2365 &if_receiverisincompatible);
2366 }
2348 2367
2349 // Check if the {receiver} is running or already closed. 2368 // Check if the {receiver} is running or already closed.
2350 Node* receiver_continuation = assembler->LoadObjectField(
2351 receiver, JSGeneratorObject::kContinuationOffset);
2352 Label if_receiverisclosed(assembler, Label::kDeferred), 2369 Label if_receiverisclosed(assembler, Label::kDeferred),
2353 if_receiverisrunning(assembler, Label::kDeferred); 2370 if_receiverisrunning(assembler, Label::kDeferred);
2354 assembler->GotoIf(assembler->SmiEqual(receiver_continuation, zero), 2371 if (type == ResumeType::Generator || FLAG_debug_code) {
2355 &if_receiverisclosed); 2372 Node* receiver_continuation = assembler->LoadObjectField(
2356 assembler->GotoIf(assembler->SmiLessThan(receiver_continuation, zero), 2373 receiver, JSGeneratorObject::kContinuationOffset);
2357 &if_receiverisrunning); 2374 assembler->GotoIf(assembler->SmiEqual(receiver_continuation, zero),
2375 &if_receiverisclosed);
2376 assembler->GotoIf(assembler->SmiLessThan(receiver_continuation, zero),
2377 &if_receiverisrunning);
2378 }
2358 2379
2359 // Resume the {receiver} using our trampoline. 2380 // Resume the {receiver} using our trampoline.
2360 Node* result = assembler->CallStub( 2381 Node* result = assembler->CallStub(
2361 CodeFactory::ResumeGenerator(assembler->isolate()), context, value, 2382 CodeFactory::ResumeGenerator(assembler->isolate()), context, value,
2362 receiver, assembler->SmiConstant(Smi::FromInt(resume_mode))); 2383 receiver, assembler->SmiConstant(Smi::FromInt(resume_mode)));
2363 assembler->Return(result); 2384 assembler->Return(result);
2364 2385
2365 assembler->Bind(&if_receiverisincompatible); 2386 assembler->Bind(&if_receiverisincompatible);
2366 { 2387 if (type == ResumeType::Generator || FLAG_debug_code) {
2367 // The {receiver} is not a valid JSGeneratorObject. 2388 // The {receiver} is not a valid JSGeneratorObject.
2368 Node* result = assembler->CallRuntime( 2389 Node* result = assembler->CallRuntime(
2369 Runtime::kThrowIncompatibleMethodReceiver, context, 2390 Runtime::kThrowIncompatibleMethodReceiver, context,
2370 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked( 2391 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked(
2371 method_name, TENURED)), 2392 method_name, TENURED)),
2372 receiver); 2393 receiver);
2373 assembler->Return(result); // Never reached. 2394 assembler->Return(result); // Never reached.
2374 } 2395 }
2375 2396
2376 assembler->Bind(&if_receiverisclosed); 2397 if (type == ResumeType::Generator || FLAG_debug_code) {
2377 { 2398 assembler->Bind(&if_receiverisclosed);
2378 // The {receiver} is closed already. 2399 // The {receiver} is closed already.
2379 Node* result = nullptr; 2400 Node* result = nullptr;
2380 switch (resume_mode) { 2401 switch (resume_mode) {
2381 case JSGeneratorObject::kNext: 2402 case JSGeneratorObject::kNext:
2382 result = assembler->CallRuntime(Runtime::kCreateIterResultObject, 2403 result = assembler->CallRuntime(Runtime::kCreateIterResultObject,
2383 context, assembler->UndefinedConstant(), 2404 context, assembler->UndefinedConstant(),
2384 assembler->BooleanConstant(true)); 2405 assembler->BooleanConstant(true));
2385 break; 2406 break;
2386 case JSGeneratorObject::kReturn: 2407 case JSGeneratorObject::kReturn:
2387 result = 2408 result =
2388 assembler->CallRuntime(Runtime::kCreateIterResultObject, context, 2409 assembler->CallRuntime(Runtime::kCreateIterResultObject, context,
2389 value, assembler->BooleanConstant(true)); 2410 value, assembler->BooleanConstant(true));
2390 break; 2411 break;
2391 case JSGeneratorObject::kThrow: 2412 case JSGeneratorObject::kThrow:
2392 result = assembler->CallRuntime(Runtime::kThrow, context, value); 2413 result = assembler->CallRuntime(Runtime::kThrow, context, value);
2393 break; 2414 break;
2394 } 2415 }
2395 assembler->Return(result); 2416 assembler->Return(result);
2396 } 2417 }
2397 2418
2398 assembler->Bind(&if_receiverisrunning); 2419 if (type == ResumeType::Generator || FLAG_debug_code) {
2399 { 2420 assembler->Bind(&if_receiverisrunning);
2400 Node* result = 2421 Node* result =
2401 assembler->CallRuntime(Runtime::kThrowGeneratorRunning, context); 2422 assembler->CallRuntime(Runtime::kThrowGeneratorRunning, context);
2402 assembler->Return(result); // Never reached. 2423 assembler->Return(result); // Never reached.
2403 } 2424 }
2404 } 2425 }
2405 2426
2406 } // namespace 2427 } // namespace
2407 2428
2408 // ES6 section 25.3.1.2 Generator.prototype.next ( value ) 2429 // ES6 section 25.3.1.2 Generator.prototype.next ( value )
2409 void Builtins::Generate_GeneratorPrototypeNext( 2430 void Builtins::Generate_GeneratorPrototypeNext(
2410 compiler::CodeStubAssembler* assembler) { 2431 compiler::CodeStubAssembler* assembler) {
2411 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext, 2432 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext,
2412 "[Generator].prototype.next"); 2433 "[Generator].prototype.next",
2434 ResumeType::Generator);
2413 } 2435 }
2414 2436
2415 // ES6 section 25.3.1.3 Generator.prototype.return ( value ) 2437 // ES6 section 25.3.1.3 Generator.prototype.return ( value )
2416 void Builtins::Generate_GeneratorPrototypeReturn( 2438 void Builtins::Generate_GeneratorPrototypeReturn(
2417 compiler::CodeStubAssembler* assembler) { 2439 compiler::CodeStubAssembler* assembler) {
2418 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kReturn, 2440 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kReturn,
2419 "[Generator].prototype.return"); 2441 "[Generator].prototype.return",
2442 ResumeType::Generator);
2420 } 2443 }
2421 2444
2422 // ES6 section 25.3.1.4 Generator.prototype.throw ( exception ) 2445 // ES6 section 25.3.1.4 Generator.prototype.throw ( exception )
2423 void Builtins::Generate_GeneratorPrototypeThrow( 2446 void Builtins::Generate_GeneratorPrototypeThrow(
2424 compiler::CodeStubAssembler* assembler) { 2447 compiler::CodeStubAssembler* assembler) {
2425 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow, 2448 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow,
2426 "[Generator].prototype.throw"); 2449 "[Generator].prototype.throw",
2450 ResumeType::Generator);
2451 }
2452
2453 void Builtins::Generate_AsyncFunctionNext(
2454 compiler::CodeStubAssembler* assembler) {
2455 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kNext,
2456 "[AsyncFunction].next", ResumeType::Async);
2457 }
2458
2459 void Builtins::Generate_AsyncFunctionThrow(
2460 compiler::CodeStubAssembler* assembler) {
2461 Generate_GeneratorPrototypeResume(assembler, JSGeneratorObject::kThrow,
2462 "[AsyncFunction].throw", ResumeType::Async);
2427 } 2463 }
2428 2464
2429 // ----------------------------------------------------------------------------- 2465 // -----------------------------------------------------------------------------
2430 // ES6 section 26.1 The Reflect Object 2466 // ES6 section 26.1 The Reflect Object
2431 2467
2432 // ES6 section 26.1.3 Reflect.defineProperty 2468 // ES6 section 26.1.3 Reflect.defineProperty
2433 BUILTIN(ReflectDefineProperty) { 2469 BUILTIN(ReflectDefineProperty) {
2434 HandleScope scope(isolate); 2470 HandleScope scope(isolate);
2435 DCHECK_EQ(4, args.length()); 2471 DCHECK_EQ(4, args.length());
2436 Handle<Object> target = args.at<Object>(1); 2472 Handle<Object> target = args.at<Object>(1);
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
5311 BUILTIN_LIST_T(DEFINE_BUILTIN_ACCESSOR_T) 5347 BUILTIN_LIST_T(DEFINE_BUILTIN_ACCESSOR_T)
5312 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 5348 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
5313 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 5349 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
5314 #undef DEFINE_BUILTIN_ACCESSOR_C 5350 #undef DEFINE_BUILTIN_ACCESSOR_C
5315 #undef DEFINE_BUILTIN_ACCESSOR_A 5351 #undef DEFINE_BUILTIN_ACCESSOR_A
5316 #undef DEFINE_BUILTIN_ACCESSOR_T 5352 #undef DEFINE_BUILTIN_ACCESSOR_T
5317 #undef DEFINE_BUILTIN_ACCESSOR_H 5353 #undef DEFINE_BUILTIN_ACCESSOR_H
5318 5354
5319 } // namespace internal 5355 } // namespace internal
5320 } // namespace v8 5356 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/compiler.cc » ('j') | src/contexts.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698