Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected [1]
without PlzNavigate.  Replication of the test flags is still desirable,
so to make the tests behave the same with and without --site-per-process
we suppress dumping of these kinds of callbacks - we can do this,
because verification of the presence of this callbacks was not essential
to the core verification done by the tests (that cross-site access is
blocked).

[1] https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4Px0/discussion

BUG=587175
Committed: https://crrev.com/a6981af455b7fdff83b6b929d9d7be95b27f2cc2
Cr-Commit-Position: refs/heads/master@{#388512}

[Łukasz Anforowicz, 2016-04-18 18:43:44]

Description was changed from

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

BUG=587175
==========

to

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected without
PlzNavigate.  Replication of the test flags is still desirable, so to
make the tests behave the same with and without --site-per-process we
suppress dumping of these kinds of callbacks - we can do this, because
verification of the presence of this callbacks was not essential to the
core verification done by the tests (that cross-site access is blocked).

BUG=587175
==========

[Łukasz Anforowicz, 2016-04-18 18:44:48]

Description was changed from

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected without
PlzNavigate.  Replication of the test flags is still desirable, so to
make the tests behave the same with and without --site-per-process we
suppress dumping of these kinds of callbacks - we can do this, because
verification of the presence of this callbacks was not essential to the
core verification done by the tests (that cross-site access is blocked).

BUG=587175
==========

to

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected [1]
without PlzNavigate.  Replication of the test flags is still desirable,
so to make the tests behave the same with and without --site-per-process
we suppress dumping of these kinds of callbacks - we can do this,
because verification of the presence of this callbacks was not essential
to the core verification done by the tests (that cross-site access is
blocked).

[1]
https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4P...

BUG=587175
==========

[Łukasz Anforowicz, 2016-04-18 18:45:46]

lukasza@chromium.org changed reviewers:
+ mkwst@chromium.org

[Łukasz Anforowicz, 2016-04-18 18:45:47]

mkwst@, could you please take a look?

This CL adds a bunch of layout test runtime flags to the set of flags that gets
replicated across all renderer processes.  This is desirable - in general, it
makes tests behave in the same way with and without --site-per-process flag. 
jochen@ was reviewing the core CLs that enabled the replication mechanism and I
am slowly adding more flags to the replicated set.

I am asking you for review, because you authored 2 tests that I need to modify,
so that they behave the same with and without --site-per-process.  I am doing
this by suppressing dumping of WebFrameClient::didFinishResourceLoad and
WebFrameClient::willSendRequest.  I think this is fine, because the essence of
the tests is to verify that cross-site access is blocked (and this verification
remains active / the removed callback dumps were not IMO helping with this
verification).  Some more details are at
https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4P...
(also linked from CL description).

[Mike West, 2016-04-20 08:07:03]

LGTM. I agree that the test changes are benign, and the code changes look pretty
reasonable. Thanks!

[Łukasz Anforowicz, 2016-04-20 14:53:10]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:53:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895543002/40001

[commit-bot: I haz the power, 2016-04-20 16:15:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:24:02]

Description was changed from

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected [1]
without PlzNavigate.  Replication of the test flags is still desirable,
so to make the tests behave the same with and without --site-per-process
we suppress dumping of these kinds of callbacks - we can do this,
because verification of the presence of this callbacks was not essential
to the core verification done by the tests (that cross-site access is
blocked).

[1]
https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4P...

BUG=587175
==========

to

==========
Replicate across OOPIFs flags for dumping of various WebFrameClient callbacks.

The replicated flags mean that in some cases test output includes
"duplicated" calls to WebFrameClient::willSendRequest and/or
WebFrameClient::didFinishResourceLoad methods.  This is expected [1]
without PlzNavigate.  Replication of the test flags is still desirable,
so to make the tests behave the same with and without --site-per-process
we suppress dumping of these kinds of callbacks - we can do this,
because verification of the presence of this callbacks was not essential
to the core verification done by the tests (that cross-site access is
blocked).

[1]
https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4P...

BUG=587175

Committed: https://crrev.com/a6981af455b7fdff83b6b929d9d7be95b27f2cc2
Cr-Commit-Position: refs/heads/master@{#388512}
==========

[commit-bot: I haz the power, 2016-04-22 19:24:03]

Patchset 3 (id:??) landed as
https://crrev.com/a6981af455b7fdff83b6b929d9d7be95b27f2cc2
Cr-Commit-Position: refs/heads/master@{#388512}