Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189553007: cc: modify the waiting condition of forced commit (Closed)

Created:
6 years, 9 months ago by simonhong
Modified:
6 years, 9 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, hyojun.im_lge.com
Visibility:
Public.

Description

cc: modify the waiting condition of forced commit Forced commit only should proceed to its BeginMainFrame when there is a scheduled BeginMainFrame(). So, Forced commit only should wait for COMMIT_STATE_BEGIN_MAIN_FRAME_SENT. R=brianderson@chromium.org BUG=350585 TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M cc/scheduler/scheduler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
simonhong
PTAL!
6 years, 9 months ago (2014-03-08 00:31:30 UTC) #1
brianderson
lgtm
6 years, 9 months ago (2014-03-08 00:35:30 UTC) #2
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-08 00:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/189553007/1
6 years, 9 months ago (2014-03-08 11:17:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:10:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234372
6 years, 9 months ago (2014-03-08 14:10:23 UTC) #6
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-08 14:18:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/189553007/1
6 years, 9 months ago (2014-03-08 14:19:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:56:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234400
6 years, 9 months ago (2014-03-08 14:56:05 UTC) #10
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-08 21:59:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/189553007/1
6 years, 9 months ago (2014-03-08 22:00:05 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 22:40:58 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234599
6 years, 9 months ago (2014-03-08 22:40:59 UTC) #14
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-09 19:13:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/189553007/1
6 years, 9 months ago (2014-03-09 19:13:44 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 07:10:04 UTC) #17
Message was sent while issue was closed. 
Change committed as 255894

Powered by Google App Engine
This is Rietveld 408576698