|
Revert of Browser Side Text Input State Tracking for OOPIF. (patchset #28 id:720001 of https://codereview.chromium.org/1652483002/ )
Reason for revert:
This patch caused many regressions.
Original issue's description:
> Browser Side Text Input State Tracking for OOPIF.
>
> Currently, the TextInputStateChanged method is not implemented in RenderWidgetHostViewChildFrame. Conequently, the IME
> will not work until this feature is fixed.
>
> This CL implements the text input state tracking through refactoring most of the TextInputStateChanged code to the top-level RenderWidgetHostViewBase.
>
> This CL should also fix a previously reported race condition in the palindrome crbug.com/546645 caused by RenderWidgetHostViewGuest's way of handling TextInputStateChanged.
>
> BUG= 578168, 546645
>
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/2bd4a2f0c0f114979d47f4498ea1bce9b091591e
> Cr-Commit-Position: refs/heads/master@{#385537}
TBR=kenrb@chromium.org,creis@chromium.org,shuchen@chromium.org,lazyboy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 578168, 546645
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+172 lines, -875 lines) |
Patch |
 |
M |
chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
|
View
|
|
4 chunks |
+0 lines, -108 lines |
0 comments
|
Download
|
 |
D |
chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
D |
chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
D |
chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
 |
D |
chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js
|
View
|
|
1 chunk |
+0 lines, -27 lines |
0 comments
|
Download
|
 |
M |
content/DEPS
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/browser_plugin/browser_plugin_guest.h
|
View
|
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/browser/browser_plugin/browser_plugin_guest.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/interstitial_page_impl.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/interstitial_page_impl.cc
|
View
|
|
3 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_child_frame.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_child_frame.cc
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
|
View
|
|
2 chunks |
+1 line, -9 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_guest.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_guest.cc
|
View
|
|
2 chunks |
+12 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_widget_host_view_guest_unittest.cc
|
View
|
|
3 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_delegate.h
|
View
|
|
3 chunks |
+2 lines, -14 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_delegate.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_impl.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_unittest.cc
|
View
|
|
4 chunks |
+1 line, -9 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_android.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_android.cc
|
View
|
|
2 chunks |
+12 lines, -13 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura.h
|
View
|
|
3 chunks |
+12 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura.cc
|
View
|
|
5 chunks |
+26 lines, -32 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
|
View
|
|
4 chunks |
+1 line, -10 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_base.h
|
View
|
|
8 chunks |
+6 lines, -31 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_base.cc
|
View
|
|
4 chunks |
+0 lines, -50 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mac.h
|
View
|
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mac.mm
|
View
|
|
2 chunks |
+14 lines, -18 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
|
View
|
|
2 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mus.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mus.cc
|
View
|
|
3 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
 |
M |
content/browser/site_per_process_browsertest.h
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
content/browser/site_per_process_browsertest.cc
|
View
|
|
3 chunks |
+2 lines, -213 lines |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_impl.h
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
3 chunks |
+0 lines, -40 lines |
0 comments
|
Download
|
 |
D |
content/common/text_input_state.h
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
 |
D |
content/common/text_input_state.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
content/common/view_messages.h
|
View
|
|
4 chunks |
+40 lines, -16 lines |
0 comments
|
Download
|
 |
M |
content/content_common.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/public/test/browser_test_utils.h
|
View
|
|
2 chunks |
+0 lines, -18 lines |
0 comments
|
Download
|
 |
M |
content/public/test/browser_test_utils.cc
|
View
|
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_view_browsertest.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_widget.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
D |
content/test/data/textinput/page_with_input.html
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
content/test/data/textinput/page_with_input_iframeX2_input.html
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
content/test/test_render_view_host.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/test/test_render_view_host.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
Total messages: 4 (2 generated)
|