Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1895513002: TaskScheduler [12] Support SINGLE_THREADED in SchedulerThreadPool DO NOT SUBMIT (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@10_superstack
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler [12] Support SINGLE_THREADED in SchedulerThreadPool. With this CL, SchedulerThreadPool::CreateTaskRunnerWithTraits supports the SINGLE_THREADED execution mode. A SINGLE_THREADED TaskRunner runs all its tasks in the same worker thread. BUG=553459

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -45 lines) Patch
M base/task_scheduler/scheduler_thread_pool.h View 1 4 chunks +8 lines, -5 lines 0 comments Download
M base/task_scheduler/scheduler_thread_pool.cc View 1 7 chunks +79 lines, -26 lines 0 comments Download
M base/task_scheduler/scheduler_thread_pool_unittest.cc View 7 chunks +23 lines, -7 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread.cc View 1 5 chunks +31 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 8 months ago (2016-04-15 18:50:48 UTC) #2
gab
lg w/ requests below https://codereview.chromium.org/1895513002/diff/1/base/task_scheduler/scheduler_thread_pool.cc File base/task_scheduler/scheduler_thread_pool.cc (right): https://codereview.chromium.org/1895513002/diff/1/base/task_scheduler/scheduler_thread_pool.cc#newcode180 base/task_scheduler/scheduler_thread_pool.cc:180: for (const auto& current_worker_thread : ...
4 years, 8 months ago (2016-04-18 19:06:35 UTC) #4
fdoray
Just replying to one comment. https://codereview.chromium.org/1895513002/diff/1/base/task_scheduler/scheduler_thread_pool.cc File base/task_scheduler/scheduler_thread_pool.cc (right): https://codereview.chromium.org/1895513002/diff/1/base/task_scheduler/scheduler_thread_pool.cc#newcode189 base/task_scheduler/scheduler_thread_pool.cc:189: break; On 2016/04/18 19:06:35, ...
4 years, 8 months ago (2016-04-18 19:47:14 UTC) #5
robliao
On 2016/04/18 19:47:14, fdoray wrote: > Just replying to one comment. > > https://codereview.chromium.org/1895513002/diff/1/base/task_scheduler/scheduler_thread_pool.cc > ...
4 years, 8 months ago (2016-04-22 01:06:21 UTC) #6
fdoray
4 years, 8 months ago (2016-04-22 13:08:49 UTC) #7
The atomic counter of number of TaskRunners per worker thread might be reused,
but most of the CL becomes obsolete with the latest
https://codereview.chromium.org/1876363004/ You shouldn't review it until I
remove DO NOT SUBMIT.

Powered by Google App Engine
This is Rietveld 408576698