Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: pnacl/driver/pnacl-abicheck.py

Issue 18955003: Pass file format argument from driver to pnacl-abicheck (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/driver/pnacl-abicheck.py
diff --git a/pnacl/driver/pnacl-abicheck.py b/pnacl/driver/pnacl-abicheck.py
index 5121452a4231cf66cac77f60f71652cb02415b2e..30011f29361a2f277b7fab4d61d775d6ff45aa67 100644
--- a/pnacl/driver/pnacl-abicheck.py
+++ b/pnacl/driver/pnacl-abicheck.py
@@ -9,8 +9,9 @@
# updates the copy in the toolchain/ tree.
#
-import driver_env
+from driver_env import env
import driver_tools
+import pathtools
EXTRA_ENV = {
'ARGS' : '',
@@ -21,9 +22,13 @@ PATTERNS = [
]
def main(argv):
- driver_env.env.update(EXTRA_ENV)
+ env.update(EXTRA_ENV)
driver_tools.ParseArgs(argv, PATTERNS)
+ args = env.get('ARGS')
+ input = pathtools.normalize(args[-1])
jvoung (off chromium) 2013/07/10 00:18:29 Maybe do a sanity check the len of the args array
+ if driver_tools.IsPNaClBitcode(input):
+ env.append('ARGS', '--bitcode-format=pnacl')
driver_tools.Run('"${PNACL_ABICHECK}" ${ARGS}')
return 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698