Issue 18955003: Pass file format argument from driver to pnacl-abicheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18955003: Pass file format argument from driver to pnacl-abicheck (Closed)

Created:
7 years, 5 months ago by Derek Schuff

Modified:
7 years, 5 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Pass file format argument from driver to pnacl-abicheck R=jvoung@chromium.org, kschimpf@google.com BUG=none TEST=check a finalized pexe Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11728

Patch Set 2 : include DEPS roll #

Patch Set 3 : remove deps #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	pnacl/driver/pnacl-abicheck.py	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Derek Schuff

depends on https://codereview.chromium.org/18884003/

7 years, 5 months ago (2013-07-09 22:55:09 UTC) #1

jvoung (off chromium)

lgtm https://codereview.chromium.org/18955003/diff/1/pnacl/driver/pnacl-abicheck.py File pnacl/driver/pnacl-abicheck.py (right): https://codereview.chromium.org/18955003/diff/1/pnacl/driver/pnacl-abicheck.py#newcode29 pnacl/driver/pnacl-abicheck.py:29: input = pathtools.normalize(args[-1]) Maybe do a sanity check ...

7 years, 5 months ago (2013-07-10 00:18:29 UTC) #2