Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3272)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 1895473002: PlatformNotificationService layering cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@display_manager2
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index a9481dc006bce5b435d56617c0d618fc0cefab5d..6db9c8aadf44292f76c40deace19dea47978bffe 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -51,10 +51,6 @@ class PlatformNotificationServiceImpl
// be called from any thread.
static PlatformNotificationServiceImpl* GetInstance();
- // Returns the notification display service to use. This is overriden in tests
- // TODO(miguelg) make it private once the tests are updated
- NotificationDisplayService* GetNotificationDisplayService(Profile* profile);
-
// Load the profile corresponding to |profile_id| and perform the
// |operation| on the given notification once it has been loaded.
void ProcessPersistentNotificationOperation(
@@ -143,6 +139,10 @@ class PlatformNotificationServiceImpl
base::string16 DisplayNameForContextMessage(Profile* profile,
const GURL& origin) const;
+ // Returns the notification display service to use.
+ // This can be overriden in tests
Peter Beverloo 2016/04/25 17:40:31 // TODO(miguelg): Remove this method in favor of p
Miguel Garcia 2016/04/25 18:45:33 Done.
+ NotificationDisplayService* GetNotificationDisplayService(Profile* profile);
+
void SetNotificationDisplayServiceForTesting(
NotificationDisplayService* service);

Powered by Google App Engine
This is Rietveld 408576698