chrome/browser/notifications/notification_ui_manager_mac.mm - Issue 1895473002: PlatformNotificationService layering cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_mac.mm

Issue 1895473002: PlatformNotificationService layering cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@display_manager2

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | chrome/browser/notifications/platform_notification_service_impl.h » ('j') | chrome/browser/notifications/platform_notification_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_ui_manager_mac.mm

diff --git a/chrome/browser/notifications/notification_ui_manager_mac.mm b/chrome/browser/notifications/notification_ui_manager_mac.mm

index 29d9b2aac26e7496f74d773dc3c78891b2aaa516..1f343ee7407b4aae3d0f6d773a817f6af43787ad 100644

--- a/chrome/browser/notifications/notification_ui_manager_mac.mm

+++ b/chrome/browser/notifications/notification_ui_manager_mac.mm

@@ -179,7 +179,6 @@ void NotificationUIManagerMac::Display(const std::string& notification_id,

};

[notification_center_ deliverNotification:toast];

- notification.delegate()->Display();

}

void NotificationUIManagerMac::Close(const std::string& profile_id,