chrome/browser/notifications/platform_notification_service_impl.h - Issue 1895473002: PlatformNotificationService layering cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 1895473002: PlatformNotificationService layering cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@display_manager2

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_mac.mm ('k') | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.h

diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h

index a9481dc006bce5b435d56617c0d618fc0cefab5d..90793ee52e94607a295d0ccdc970fefbbc78c71b 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.h

+++ b/chrome/browser/notifications/platform_notification_service_impl.h

@@ -51,10 +51,6 @@ class PlatformNotificationServiceImpl

// be called from any thread.

static PlatformNotificationServiceImpl* GetInstance();

- // Returns the notification display service to use. This is overriden in tests

- // TODO(miguelg) make it private once the tests are updated

- NotificationDisplayService* GetNotificationDisplayService(Profile* profile);

// Load the profile corresponding to |profile_id| and perform the

// |operation| on the given notification once it has been loaded.

void ProcessPersistentNotificationOperation(

@@ -143,6 +139,12 @@ class PlatformNotificationServiceImpl

base::string16 DisplayNameForContextMessage(Profile* profile,

const GURL& origin) const;

+ // Returns the notification display service to use.

+ // This can be overriden in tests.

+ // TODO(miguelg): Remove this method in favor of providing a testing factory

+ // to the NotificationDisplayServiceFactory.

+ NotificationDisplayService* GetNotificationDisplayService(Profile* profile);

void SetNotificationDisplayServiceForTesting(

NotificationDisplayService* service);