Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1895443004: Pull YUV Readback tests out of gl_helper_unittest (Closed)

Created:
4 years, 8 months ago by Fady Samuel
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull YUV Readback tests out of gl_helper_unittest I'd like to put GLHelper in gpu/ to be reused by mus. I'd like to put related unit tests next to gl_helper's final destination. To do so, I decoupled the tests from media. I split up the test into gl_helper_unittest and yuv_readback_unittest which depends on media. gl_helper_unittest can now live in gpu/ BUG=601866 Committed: https://crrev.com/a06a56680ea8e000140f30466b976b61308d152a Cr-Commit-Position: refs/heads/master@{#387924}

Patch Set 1 #

Patch Set 2 : Working yuv_readback_unittest.cc #

Patch Set 3 : Simplified tests #

Patch Set 4 : Fix content_tests.gypi #

Patch Set 5 : Rebase + Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+561 lines, -405 lines) Patch
M content/browser/compositor/gl_helper_unittest.cc View 1 2 7 chunks +5 lines, -405 lines 0 comments Download
A content/browser/compositor/yuv_readback_unittest.cc View 1 2 3 4 1 chunk +554 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895443004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895443004/60001
4 years, 8 months ago (2016-04-18 03:46:05 UTC) #3
Fady Samuel
Antoine, what do you think about this split? With this CL, I think I can ...
4 years, 8 months ago (2016-04-18 03:47:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 04:39:10 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895443004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895443004/80001
4 years, 8 months ago (2016-04-18 13:31:16 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 15:29:44 UTC) #11
piman
LGTM
4 years, 8 months ago (2016-04-18 16:05:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895443004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895443004/80001
4 years, 8 months ago (2016-04-18 16:10:03 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-18 16:14:21 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 16:15:29 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a06a56680ea8e000140f30466b976b61308d152a
Cr-Commit-Position: refs/heads/master@{#387924}

Powered by Google App Engine
This is Rietveld 408576698