third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt - Issue 1895443002: [css-grid] Implement auto-repeat computation

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt

Issue 1895443002: [css-grid] Implement auto-repeat computation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Test that setting/getting grid-template-{columns\|rows} with repeat(auto-fill\|aut o-fit,) works as expected	1 Test that setting/getting grid-template-{columns\|rows} with repeat(auto-fill\|aut o-fit,) works as expected

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 Test auto-repeat syntax.	6 Test auto-repeat syntax.

7 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 10px. Was 0px.	7 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 200px [foo bar] 200px [foo bar] 200px [foo bar] 200px. Was 200p x 200px 200px 200px.
	Manuel Rego 2016/04/18 21:31:41 I'm not sure if it's a good idea to add the name l I'm not sure if it's a good idea to add the name lines if they're not supported yet. Wouldn't be better to have the test without name lines, until we support them? svillar 2016/04/19 08:09:35 I think both are valid alternatives. I don't stron Show quoted text On 2016/04/18 21:31:41, Manuel Rego wrote: > I'm not sure if it's a good idea to add the name lines > if they're not supported yet. > Wouldn't be better to have the test without name lines, > until we support them? I think both are valid alternatives. I don't strongly feel about any.
8 PASS element.style.gridTemplateColumns is "repeat(auto-fill, [foo bar] 10px)"	8 PASS element.style.gridTemplateColumns is "repeat(auto-fill, [foo bar] 200px)"

9 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 20px [foo bar]. Was 0px.	9 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 200px [foo bar] 200px [foo bar] 200px [foo bar]. Was 200px 200px 200px.

10 PASS element.style.gridTemplateRows is "repeat(auto-fill, 2em [foo bar])"	10 PASS element.style.gridTemplateRows is "repeat(auto-fill, 20em [foo bar])"

11 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 800px. Was 0px.	11 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 400px [foo bar] 400px. Was 400px 400px.

12 PASS element.style.gridTemplateColumns is "repeat(auto-fill, [foo bar] minmax(10 px, 1fr))"	12 PASS element.style.gridTemplateColumns is "repeat(auto-fill, [foo bar] minmax(30 0px, 1fr))"

13 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be [foo] 20px [bar]. Was 0px.	13 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be [foo] 175px [bar foo] 175px [bar foo] 175px [bar]. Was 175px 175px 175px.

14 PASS element.style.gridTemplateRows is "repeat(auto-fill, [foo] minmax(2em, max- content) [bar])"	14 PASS element.style.gridTemplateRows is "repeat(auto-fill, [foo] minmax(175px, ma x-content) [bar])"

15 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be 100px 20px 20px. Was 20px 20px.	15 PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "100px 100px 100px 250px 250px"

16 PASS element.style.gridTemplateColumns is "repeat(auto-fill, minmax(10px, 100px) ) 20px 20px"	16 PASS element.style.gridTemplateColumns is "repeat(auto-fill, minmax(50px, 100px) ) 250px 250px"

17 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 70px 20px [bar foo] 10px [foo] 10px. Was 70px 10px [foo] 10px [foo].	17 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 450px 50px [bar] 50px [bar foo] 10px [foo] 10px. Was 450px 50px [foo] 50px [ foo] 10px 10px.

18 PASS element.style.gridTemplateRows is "70px repeat(auto-fill, minmax(2em, max-c ontent) [bar]) [foo] 1em [foo] 1em"	18 PASS element.style.gridTemplateRows is "450px repeat(auto-fill, minmax(5em, max- content) [bar]) [foo] 1em [foo] 1em"

19 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 10px. Was 0px.	19 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be none. Was 150px 150px 150px 150px 150px.
	Manuel Rego 2016/04/18 21:31:41 Like in the previous case, I'm not sure if we want Like in the previous case, I'm not sure if we want to expect "none" in this test. I understand that would be the result once we implement "auto-fit", but right now I'd prefer to have a PASS with the wrong result and a TODO, that the "none" (it's pretty confusing if you read the test). svillar 2016/04/19 08:19:23 BTW I have to disagree with this. A FAIL is pretty Show quoted text On 2016/04/18 21:31:41, Manuel Rego wrote: > Like in the previous case, I'm not sure if we want to expect "none" > in this test. > I understand that would be the result once we implement "auto-fit", > but right now I'd prefer to have a PASS with the wrong result and > a TODO, that the "none" (it's pretty confusing if you read the test). BTW I have to disagree with this. A FAIL is pretty explicit. A PASS with a TODO in another file is not at all. Manuel Rego 2016/04/19 11:37:30 Of course it's a personal preference, the TODO can Show quoted text On 2016/04/19 08:19:23, svillar wrote: > On 2016/04/18 21:31:41, Manuel Rego wrote: > > Like in the previous case, I'm not sure if we want to expect "none" > > in this test. > > I understand that would be the result once we implement "auto-fit", > > but right now I'd prefer to have a PASS with the wrong result and > > a TODO, that the "none" (it's pretty confusing if you read the test). > > BTW I have to disagree with this. A FAIL is pretty explicit. A PASS with a TODO > in another file is not at all. Of course it's a personal preference, the TODO can even be in the test. :-) In my case, if I read a test, I expect everything to be "PASS" unless I find some special comment like a TODO. Anyway, in this case it's a temporal situation, that hopefully won't last for a long time (next patches will be coming soon), so I don't have a strong opinion either.
20 PASS element.style.gridTemplateColumns is "repeat(auto-fit, [foo bar] 10px)"	20 PASS element.style.gridTemplateColumns is "repeat(auto-fit, [foo bar] 150px)"

21 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 20px [foo bar]. Was 0px.	21 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be none. Was 240px 240px.

22 PASS element.style.gridTemplateRows is "repeat(auto-fit, 2em [foo bar])"	22 PASS element.style.gridTemplateRows is "repeat(auto-fit, 24em [foo bar])"

23 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be [foo bar] 800px. Was 0px.	23 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be none. Was 400px 400px.

24 PASS element.style.gridTemplateColumns is "repeat(auto-fit, [foo bar] minmax(10p x, 1fr))"	24 PASS element.style.gridTemplateColumns is "repeat(auto-fit, [foo bar] minmax(270 px, 1fr))"

25 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be [foo] 20px [bar]. Was 0px.	25 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be none. Was 200px 200px 200px.

26 PASS element.style.gridTemplateRows is "repeat(auto-fit, [foo] minmax(2em, max-c ontent) [bar])"	26 PASS element.style.gridTemplateRows is "repeat(auto-fit, [foo] minmax(20em, max- content) [bar])"

27 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be 10px 20px 20px. Was 20px 20px.	27 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-columns') sho uld be 20px 20px. Was 300px 300px 20px 20px.

28 PASS element.style.gridTemplateColumns is "repeat(auto-fit, minmax(10px, min-con tent)) 20px 20px"	28 PASS element.style.gridTemplateColumns is "repeat(auto-fit, minmax(300px, min-co ntent)) 20px 20px"

29 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 60px 20px [bar foo] 10px [foo] 10px. Was 60px 10px [foo] 10px [foo].	29 FAIL getComputedStyle(element, '').getPropertyValue('grid-template-rows') should be 60px [foo] 10px [foo] 10px. Was 60px 300px [foo] 10px [foo] 10px.

30 PASS element.style.gridTemplateRows is "10% repeat(auto-fit, minmax(2em, max-con tent) [bar]) [foo] 1em [foo] 1em"	30 PASS element.style.gridTemplateRows is "10% repeat(auto-fit, minmax(30em, max-co ntent) [bar]) [foo] 1em [foo] 1em"

31	31

32 Test invalid repeat syntax.	32 Test invalid repeat syntax.

33 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	33 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

34 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	34 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

35 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	35 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

36 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	36 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

37 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	37 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

38 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	38 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

39 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	39 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

40 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	40 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

(...skipping 10 matching lines...) Expand all Loading...
51 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	51 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

52 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	52 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

53 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	53 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

54 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	54 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

55 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	55 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

56 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"	56 PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-column s') is "none"

57 PASS successfullyParsed is true	57 PASS successfullyParsed is true

58	58

59 TEST COMPLETE	59 TEST COMPLETE

60	60

OLD	NEW