Source/platform/Supplementable.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/Supplementable.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/Supplementable.h

diff --git a/Source/platform/Supplementable.h b/Source/platform/Supplementable.h

index 6df209b43597b8f4e0324baaaf8e4dd99ed89c0d..9b29c653f89c02967d1b0914400cd6f29f0b185e 100644

--- a/Source/platform/Supplementable.h

+++ b/Source/platform/Supplementable.h

@@ -119,12 +119,14 @@ public:

};

template<>

-class SupplementTracing<false> { };

+class SupplementTracing<false> {

+public:

+ virtual ~SupplementTracing() { }

+};

template<typename T, bool isGarbageCollected = false>

class SupplementBase : public SupplementTracing<isGarbageCollected> {

public:

- virtual ~SupplementBase() { }

#if SECURITY_ASSERT_ENABLED

virtual bool isRefCountedWrapper() const { return false; }

#endif