Source/modules/performance/WorkerGlobalScopePerformance.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/performance/WorkerGlobalScopePerformance.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/performance/WorkerGlobalScopePerformance.h

diff --git a/Source/modules/performance/WorkerGlobalScopePerformance.h b/Source/modules/performance/WorkerGlobalScopePerformance.h

index e84ae20256f1326ea7a31b698c68e7c594fd3a74..5ce1ac0cbbbbd77bc667e5af32a4932e49729159 100644

--- a/Source/modules/performance/WorkerGlobalScopePerformance.h

+++ b/Source/modules/performance/WorkerGlobalScopePerformance.h

@@ -42,7 +42,6 @@ class WorkerGlobalScope;

class WorkerGlobalScopePerformance FINAL : public NoBaseWillBeGarbageCollected<WorkerGlobalScopePerformance>, public WillBeHeapSupplement<WorkerGlobalScope> {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerGlobalScopePerformance);

public:

- virtual ~WorkerGlobalScopePerformance();

static WorkerGlobalScopePerformance& from(WorkerGlobalScope&);

static WorkerPerformance* performance(WorkerGlobalScope&);

« Source/heap/Handle.h ('K') | « Source/modules/gamepad/GamepadList.h ('k') | Source/modules/performance/WorkerGlobalScopePerformance.cpp » ('j') | no next file with comments »