Source/modules/crypto/WorkerGlobalScopeCrypto.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/WorkerGlobalScopeCrypto.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/crypto/WorkerGlobalScopeCrypto.h

diff --git a/Source/modules/crypto/WorkerGlobalScopeCrypto.h b/Source/modules/crypto/WorkerGlobalScopeCrypto.h

index 6774a9a1b71eea697fb1b14ad01c2ae4da719975..b06b1c70ce1b1a026821cfd31703c0e41041d366 100644

--- a/Source/modules/crypto/WorkerGlobalScopeCrypto.h

+++ b/Source/modules/crypto/WorkerGlobalScopeCrypto.h

@@ -44,7 +44,6 @@ class WorkerGlobalScope;

class WorkerGlobalScopeCrypto FINAL : public NoBaseWillBeGarbageCollected<WorkerGlobalScopeCrypto>, public WillBeHeapSupplement<WorkerGlobalScope> {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerGlobalScopeCrypto);

public:

- virtual ~WorkerGlobalScopeCrypto();

static WorkerGlobalScopeCrypto& from(WillBeHeapSupplementable<WorkerGlobalScope>&);

static WorkerCrypto* crypto(WillBeHeapSupplementable<WorkerGlobalScope>&);

WorkerCrypto* crypto() const;