Source/heap/Heap.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/heap/Heap.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/heap/Heap.h

diff --git a/Source/heap/Heap.h b/Source/heap/Heap.h

index 8e59b282ccba646aaba34729cd57304048e120b3..35ba29aacd1c5c24f7cd042f589053b8f3e4f915 100644

--- a/Source/heap/Heap.h

+++ b/Source/heap/Heap.h

@@ -895,7 +895,6 @@ protected:

{

ASSERT(ThreadStateFor<ThreadingTrait<T>::Affinity>::state()->contains(reinterpret_cast<Address>(this)));

}

- ~GarbageCollected() { }

};

// Base class for objects allocated in the Blink garbage-collected