Source/core/css/Rect.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/Rect.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/Rect.h

diff --git a/Source/core/css/Rect.h b/Source/core/css/Rect.h

index 71417e0da25f7043802a9cca7bc953dae467622f..92ca6def59707f7dbc35e6e5e2febe6f44a5df8c 100644

--- a/Source/core/css/Rect.h

+++ b/Source/core/css/Rect.h

@@ -28,6 +28,7 @@

namespace WebCore {

class RectBase : public RefCountedWillBeGarbageCollected<RectBase> {

+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_NONE(RectBase);

public:

CSSPrimitiveValue* top() const { return m_top.get(); }

CSSPrimitiveValue* right() const { return m_right.get(); }

@@ -49,8 +50,6 @@ public:

void trace(Visitor*);

- ~RectBase() { }

protected:

RectBase() { }

RectBase(const RectBase& cloneFrom)