Ensure proper finalization of garbage-collected types.

Source/core/css/CSSBasicShapes.h

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 42 matching lines @@
 
     virtual Type type() const = 0;
     virtual String cssText() const = 0;
     virtual bool equals(const CSSBasicShape&) const = 0;
 
     CSSPrimitiveValue* layoutBox() const { return m_layoutBox.get(); }
     void setLayoutBox(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> layoutBox) { m_layoutBox = layoutBox; }
 
     virtual void trace(Visitor* visitor) { visitor->trace(m_layoutBox); }
 
+#if !ENABLE(OILPAN)

[haraken, 2014/03/11 10:26:37]

I'm not that happy to have a lot of ENABLE(OILPAN) flags on destructors for the
following reasons:

- It will mess up the code base.
- (If I'm understanding correctly,) if we add !ENABLE(OILPAN), compilers will
implicitly generate the destructor in the header file. This can cause #include
cycles. (That's why Blink writes empty destructors in cpp files.)

[Erik Corry, 2014/03/11 10:34:26]

This is unfortunate, but the warning from the clang plugin seems valuable.
I think this issue does not arise, because the destructors that are ifdeffed out
are only the truly trivial ones.  The classes that contain a RefPtr or an OwnPtr
in oilpan mode cannot be ifdeffed out (and the plugin will check this), and
those are the ones that would have caused problems when implicitly generated in
the header file.

 public:
     virtual ~CSSBasicShape() { }
+#endif
 
 protected:
     CSSBasicShape() { }
     RefPtrWillBeMember<CSSPrimitiveValue> m_layoutBox;
 };
 
 class CSSBasicShapeRectangle FINAL : public CSSBasicShape {
 public:
     static PassRefPtrWillBeRawPtr<CSSBasicShapeRectangle> create() { return adoptRefWillBeNoop(new CSSBasicShapeRectangle); }
 
@@ skipping 271 matching lines @@
 
     RefPtrWillBeMember<CSSPrimitiveValue> m_topLeftRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_topRightRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_bottomRightRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_bottomLeftRadius;
 };
 
 } // namespace WebCore
 
 #endif // CSSBasicShapes_h