Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: Source/core/rendering/RenderListBox.h

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update Test Expectations Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderListBox.h
diff --git a/Source/core/rendering/RenderListBox.h b/Source/core/rendering/RenderListBox.h
index cdca38562bc56affc7403ba51095b2bd44c7f81f..ab659050207e06d38f34d1fbb6725c12e1353092 100644
--- a/Source/core/rendering/RenderListBox.h
+++ b/Source/core/rendering/RenderListBox.h
@@ -47,11 +47,10 @@ public:
void setOptionsChanged(bool changed) { m_optionsChanged = changed; }
- int listIndexAtOffset(const LayoutSize&);
- LayoutRect itemBoundingBoxRect(const LayoutPoint&, int index);
+ int listIndexAtOffset(const LayoutSize&) const;
+ LayoutRect itemBoundingBoxRect(const LayoutPoint&, int index) const;
bool scrollToRevealElementAtListIndex(int index);
- bool listIndexIsVisible(int index);
int scrollToward(const IntPoint&); // Returns the new index or -1 if no scroll occurred
@@ -132,6 +131,9 @@ private:
virtual float pixelStep(ScrollbarOrientation) const OVERRIDE;
virtual IntRect scrollableAreaBoundingBox() const OVERRIDE;
+ LayoutRect itemBoundingBoxRectInternal(const LayoutPoint&, int index) const;
+ bool scrollToRevealElementAtListIndexInternal(int index);
+
// NOTE: This should only be called by the overriden setScrollOffset from ScrollableArea.
void scrollTo(int newOffset);
@@ -141,6 +143,7 @@ private:
LayoutUnit itemHeight() const;
int numVisibleItems() const;
+ bool listIndexIsVisible(int index) const;
int numItems() const;
LayoutUnit listHeight() const;
int scrollbarLeft() const;
@@ -149,11 +152,15 @@ private:
void paintItemBackground(PaintInfo&, const LayoutPoint&, int listIndex);
void scrollToRevealSelection();
+ int renderListBoxIndexToListIndex(int index) const;
+ int listIndexToRenderListBoxIndex(int index) const;
+
bool m_optionsChanged;
bool m_scrollToRevealSelectionAfterLayout;
bool m_inAutoscroll;
int m_optionsWidth;
int m_indexOffset;
+ int m_listItemCount;
RefPtr<Scrollbar> m_vBar;
};
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698