Source/core/html/HTMLSelectElement.h - Issue 189543012: Update <select> when any of its <option> children has "display: none"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addtional layout test included. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/accessibility/AXListBoxOption.cpp ('K') | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | Source/core/html/HTMLSelectElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 8268cc15a8c3508e851f1278dbdbc0c98d14753c..38c488184f51df82cd7ae630821b2ac06bee3c0b 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -115,6 +115,7 @@ public:

void optionSelectionStateChanged(HTMLOptionElement*, bool optionIsSelected);

bool anonymousIndexedSetter(unsigned, PassRefPtr<HTMLOptionElement>, ExceptionState&);

+ void updateListOnRenderer();

protected:

HTMLSelectElement(Document&, HTMLFormElement*);

@@ -155,6 +156,7 @@ private:

virtual bool isOptionalFormControl() const OVERRIDE { return !isRequiredFormControl(); }

virtual bool isRequiredFormControl() const OVERRIDE;

+ virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE;

bool hasPlaceholderLabelOption() const;