Source/core/accessibility/AXListBox.cpp - Issue 189543012: Update <select> when any of its <option> children has "display: none"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXListBox.cpp

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addtional layout test included. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/select/select-with-display-none-options-expected.txt ('k') | Source/core/accessibility/AXListBoxOption.cpp » ('j') | Source/core/accessibility/AXListBoxOption.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/accessibility/AXListBox.cpp

diff --git a/Source/core/accessibility/AXListBox.cpp b/Source/core/accessibility/AXListBox.cpp

index d306616316c55295841118ba1065f0a3a96692dc..dfaae409030d582c8311078827aa4d7b6e427c3b 100644

--- a/Source/core/accessibility/AXListBox.cpp

+++ b/Source/core/accessibility/AXListBox.cpp

@@ -151,7 +151,8 @@ AXObject* AXListBox::elementAccessibilityHitTest(const IntPoint& point) const

AXObject* listBoxOption = 0;

unsigned length = m_children.size();

for (unsigned i = 0; i < length; i++) {

- LayoutRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.location(), i);

+ RenderListBox* listBox = toRenderListBox(m_renderer);

+ LayoutRect rect = listBox->itemBoundingBoxRect(parentRect.location(), listBox->toRenderListBoxIndex(i));

keishi 2014/04/11 06:40:13 Ditto. toRenderListBoxIndex should be done inside

// The cast to HTMLElement below is safe because the only other possible listItem type

// would be a WMLElement, but WML builds don't use accessibility features at all.

if (rect.contains(point)) {