Source/core/rendering/RenderListBox.h - Issue 189543012: Update <select> when any of its <option> children has "display: none"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderListBox.h

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + Layout Testcase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLSelectElement.cpp ('K') | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | Source/core/rendering/RenderListBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderListBox.h

diff --git a/Source/core/rendering/RenderListBox.h b/Source/core/rendering/RenderListBox.h

index efc47aa25103ee9bf7341490fa9a87f8ec049003..cbdd4480faa8bc05ca55cc9fbe4f3130eed1a198 100644

--- a/Source/core/rendering/RenderListBox.h

+++ b/Source/core/rendering/RenderListBox.h

@@ -154,6 +154,7 @@ private:

int m_indexOffset;

RefPtr<Scrollbar> m_vBar;

+ Vector<int> m_listItemIndex;

esprehn 2014/03/20 17:09:25 This doesn't seem right.

spartha 2014/03/21 05:13:26 Since modifying the item list on the select elemen

};

DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderListBox, isListBox());

« Source/core/html/HTMLSelectElement.cpp ('K') | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | Source/core/rendering/RenderListBox.cpp » ('J')