Update <select> when any of its <option> children has "display: none"

Source/core/html/HTMLSelectElement.h

Index: Source/core/html/HTMLSelectElement.h
diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h
index 8268cc15a8c3508e851f1278dbdbc0c98d14753c..e12f7b23049384661ce45cf4cdf59c9b5f95aaa4 100644
--- a/Source/core/html/HTMLSelectElement.h
+++ b/Source/core/html/HTMLSelectElement.h
@@ -115,6 +115,7 @@ public:
     void optionSelectionStateChanged(HTMLOptionElement*, bool optionIsSelected);
     bool anonymousIndexedSetter(unsigned, PassRefPtr<HTMLOptionElement>, ExceptionState&);
 
+    void updateListOnRenderer();
 protected:
     HTMLSelectElement(Document&, HTMLFormElement*);
 
@@ -195,6 +196,8 @@ private:
     virtual int optionCount() const OVERRIDE;
     virtual String optionAtIndex(int index) const OVERRIDE;
 
+    void timerFired(Timer<HTMLSelectElement>*);
+
     // m_listItems contains HTMLOptionElement, HTMLOptGroupElement, and HTMLHRElement objects.
     mutable Vector<HTMLElement*> m_listItems;
     Vector<bool> m_lastOnChangeSelection;
@@ -209,6 +212,7 @@ private:
     bool m_activeSelectionState;
     mutable bool m_shouldRecalcListItems;
     int m_suggestedIndex;
+    Timer<HTMLSelectElement> m_optionChildChangedTimer;

[esprehn, 2014/03/20 17:09:25]

Please remove this timer, it's not correct to use one and it creates a race.

[spartha, 2014/03/21 05:13:26]

The idea to use the timer is to avoid multiple calls to updateFromElement. I can
think of using a boolean switch on select instead. The Option elements can set a
flag on select when there is a change in display. At the end of style
recalculation I can call updateFromElement if required.

 };
 
 } // namespace