Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: Source/core/html/HTMLOptGroupElement.h

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update Test Expectations Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 21 matching lines...) Expand all
32 32
33 class HTMLOptGroupElement FINAL : public HTMLElement { 33 class HTMLOptGroupElement FINAL : public HTMLElement {
34 public: 34 public:
35 static PassRefPtr<HTMLOptGroupElement> create(Document&); 35 static PassRefPtr<HTMLOptGroupElement> create(Document&);
36 36
37 virtual bool isDisabledFormControl() const OVERRIDE; 37 virtual bool isDisabledFormControl() const OVERRIDE;
38 HTMLSelectElement* ownerSelectElement() const; 38 HTMLSelectElement* ownerSelectElement() const;
39 39
40 String groupLabelText() const; 40 String groupLabelText() const;
41 41
42 bool isDisplayNone() const;
43
42 private: 44 private:
43 explicit HTMLOptGroupElement(Document&); 45 explicit HTMLOptGroupElement(Document&);
44 46
45 virtual bool rendererIsFocusable() const OVERRIDE; 47 virtual bool rendererIsFocusable() const OVERRIDE;
46 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 48 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
47 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; } 49 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
48 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE; 50 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
49 virtual void detach(const AttachContext& = AttachContext()) OVERRIDE; 51 virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
50 52
51 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE; 53 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE;
52 54
53 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE; 55 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE;
54 56
55 // <optgroup> never has a renderer so we manually manage a cached style. 57 // <optgroup> never has a renderer so we manually manage a cached style.
56 void updateNonRenderStyle(); 58 void updateNonRenderStyle();
57 virtual RenderStyle* nonRendererStyle() const OVERRIDE; 59 virtual RenderStyle* nonRendererStyle() const OVERRIDE;
58 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE; 60 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
59 61
60 void recalcSelectOptions(); 62 void recalcSelectOptions();
61 63
62 RefPtr<RenderStyle> m_style; 64 RefPtr<RenderStyle> m_style;
63 }; 65 };
64 66
65 } //namespace 67 } //namespace
66 68
67 #endif 69 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/select/select-with-display-none-options-expected.txt ('k') | Source/core/html/HTMLOptGroupElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698