Source/core/rendering/RenderListBox.h - Issue 189543012: Update <select> when any of its <option> children has "display: none"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/RenderListBox.h

Issue 189543012: Update <select> when any of its <option> children has "display: none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch without setTimeout Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff |

OLD	NEW
1 /*	1 /*

2 * This file is part of the select element renderer in WebCore.	2 * This file is part of the select element renderer in WebCore.

3 *	3 *

4 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 *	9 *

10 * 1. Redistributions of source code must retain the above copyright	10 * 1. Redistributions of source code must retain the above copyright

(...skipping 136 matching lines...) Loading...
147 void paintItemBackground(PaintInfo&, const LayoutPoint&, int listIndex);	147 void paintItemBackground(PaintInfo&, const LayoutPoint&, int listIndex);

148 void scrollToRevealSelection();	148 void scrollToRevealSelection();

149	149

150 bool m_optionsChanged;	150 bool m_optionsChanged;

151 bool m_scrollToRevealSelectionAfterLayout;	151 bool m_scrollToRevealSelectionAfterLayout;

152 bool m_inAutoscroll;	152 bool m_inAutoscroll;

153 int m_optionsWidth;	153 int m_optionsWidth;

154 int m_indexOffset;	154 int m_indexOffset;

155	155

156 RefPtr<Scrollbar> m_vBar;	156 RefPtr<Scrollbar> m_vBar;

	157 Vector<int> m_listItemIndex;
	esprehn 2014/03/21 20:43:39 It seems unfortunate to keep this Vector the size It seems unfortunate to keep this Vector the size of the options around when almost no real pages use display: none, so this is just wasting memory. spartha 2014/03/21 21:29:03 Yeah, totally agree. The only reason I want to use Show quoted text On 2014/03/21 20:43:39, esprehn wrote: > It seems unfortunate to keep this Vector the size of the options around when > almost no real pages use display: none, so this is just wasting memory. Yeah, totally agree. The only reason I want to use it, is to keep the code simple.
157 };	158 };

158	159

159 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderListBox, isListBox());	160 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderListBox, isListBox());

160	161

161 } // namepace WebCore	162 } // namepace WebCore

162	163

163 #endif // RenderListBox_h	164 #endif // RenderListBox_h

OLD	NEW

« Source/core/html/HTMLOptionElement.cpp ('K') | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | Source/core/rendering/RenderListBox.cpp » ('J')