Update <select> when any of its <option> children has "display: none"

Source/core/html/HTMLOptionElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 285 matching lines @@
     m_style = originalStyleForRenderer();
 }
 
 RenderStyle* HTMLOptionElement::nonRendererStyle() const
 {
     return m_style.get();
 }
 
 PassRefPtr<RenderStyle> HTMLOptionElement::customStyleForRenderer()
 {
+    RefPtr<RenderStyle> oldStyle = m_style;
     updateNonRenderStyle();
+    if ((m_style->display() == NONE || (!oldStyle || oldStyle->display() == NONE)) && (!oldStyle || (m_style->display() != oldStyle->display()))) {
+        if (HTMLSelectElement* select = ownerSelectElement())
+            select->updateListOnRenderer();

[esprehn, 2014/03/20 17:09:25]

This is not the correct place to do this.

[spartha, 2014/03/21 05:13:26]

Since we don't have a renderer associated with this element, we cannot rely on
styleDidChange. I was looking for the change in display property, so added the
check here. Is there a better place to add this check? 

+    }
     return m_style;
 }
 
 void HTMLOptionElement::didRecalcStyle(StyleRecalcChange change)
 {
     if (change == NoChange)
         return;
 
     // FIXME: We ask our owner select to repaint regardless of which property changed.
     if (HTMLSelectElement* select = ownerSelectElement()) {
@@ skipping 51 matching lines @@
 }
 
 HTMLFormElement* HTMLOptionElement::form() const
 {
     if (HTMLSelectElement* selectElement = ownerSelectElement())
         return selectElement->formOwner();
 
     return 0;
 }
 
+bool HTMLOptionElement::isDisplayNone() const
+{
+    RenderStyle* style = nonRendererStyle();
+    if (style && style->display() == NONE)

[esprehn, 2014/03/20 17:09:25]

return style && style->display() == NONE;

[spartha, 2014/03/21 05:13:26]

Done.

+        return false;
+    return true;
+}
+
 } // namespace WebCore