Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: lib/src/barback/barback_server.dart

Issue 1895423002: Don't assign to final 'trace' parameter in catch clause. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/pub.git@master
Patch Set: Rebase to most recent pub Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/barback_server.dart
diff --git a/lib/src/barback/barback_server.dart b/lib/src/barback/barback_server.dart
index 3cc9f98f2b02a383593a1db79ced4a57e7c15509..2e89284a9a8eda27be9be58d5555bdde6c508f7a 100644
--- a/lib/src/barback/barback_server.dart
+++ b/lib/src/barback/barback_server.dart
@@ -135,10 +135,10 @@ class BarbackServer extends BaseServer<BarbackServerResult> {
});
}).catchError((error, trace) {
if (error is! AssetNotFoundException) {
- trace = new Chain.forTrace(trace);
- logRequest(request, "$error\n$trace");
+ var chain = new Chain.forTrace(trace);
+ logRequest(request, "$error\n$chain");
- addError(error, trace);
+ addError(error, chain);
close();
return new shelf.Response.internalServerError();
}
@@ -197,8 +197,8 @@ class BarbackServer extends BaseServer<BarbackServerResult> {
return notFound(request, error: error.toString(), asset: asset.id);
}
- trace = new Chain.forTrace(trace);
- logRequest(request, "$error\n$trace");
+ var chain = new Chain.forTrace(trace);
+ logRequest(request, "$error\n$chain");
// Otherwise, it's some internal error.
return new shelf.Response.internalServerError(body: error.toString());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698