GN: Fix bootstrap.py on mac

GN: Fix bootstrap.py on mac

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/edafde65ae1b3e753dfabdaaffddafacd6e44805
Cr-Commit-Position: refs/heads/master@{#388548}

[brettw, 2016-04-20 17:21:45]

LGTM with tweak.

https://codereview.chromium.org/1895413005/diff/1/tools/gn/bootstrap/bootstra...
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/1895413005/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:121: if is_posix:
Actually I think this file should always be generated. We don't currently use it
on Windows I guess, but that seems incidental. Can you just delete the "if" line
and un-dent the block?

[kal, 2016-04-20 18:36:30]

On 2016/04/20 17:21:45, brettw wrote:
> LGTM with tweak.
> 
>
https://codereview.chromium.org/1895413005/diff/1/tools/gn/bootstrap/bootstra...
> File tools/gn/bootstrap/bootstrap.py (right):
> 
>
https://codereview.chromium.org/1895413005/diff/1/tools/gn/bootstrap/bootstra...
> tools/gn/bootstrap/bootstrap.py:121: if is_posix:
> Actually I think this file should always be generated. We don't currently use
it
> on Windows I guess, but that seems incidental. Can you just delete the "if"
line
> and un-dent the block?

Ok I made your suggested tweak.

[kal, 2016-04-20 18:36:57]

The CQ bit was checked by kcconley@gmail.com

[kal, 2016-04-20 18:36:58]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1895413005/#ps20001
(title: "create features.h on all platforms")

[commit-bot: I haz the power, 2016-04-20 18:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895413005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895413005/20001

[commit-bot: I haz the power, 2016-04-20 19:30:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:25:22]

Description was changed from

==========
GN: Fix bootstrap.py on mac

R=brettw@chromium.org
BUG=
==========

to

==========
GN: Fix bootstrap.py on mac

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/edafde65ae1b3e753dfabdaaffddafacd6e44805
Cr-Commit-Position: refs/heads/master@{#388548}
==========

[commit-bot: I haz the power, 2016-04-22 19:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/edafde65ae1b3e753dfabdaaffddafacd6e44805
Cr-Commit-Position: refs/heads/master@{#388548}