third_party/WebKit/Source/core/dom/Document.cpp - Issue 1895323002: Viewport apply scroll should be on the document element not scrollingElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1895323002: Viewport apply scroll should be on the document element not scrollingElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 5ba449da09f6838f13fb7d2f535a713d92be2708..19433b1896d94564fb1a5fedae29e4757a4973de 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -593,12 +593,7 @@ void Document::updateViewportApplyScroll()

|| ownerElement())

return;

- Element* newScrollingElement = scrollingElement();

- // If there is no scrolling element (in QuirksMode and body is scrollable),

- // install the viewport scroll callback on the <HTML> element.

- if (!newScrollingElement)

- newScrollingElement = m_documentElement;

+ Element* newScrollingElement = m_documentElement;

if (newScrollingElement == m_oldScrollingElement)

return;

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »