third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h - Issue 1895323002: Viewport apply scroll should be on the document element not scrollingElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

Issue 1895323002: Viewport apply scroll should be on the document element not scrollingElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

index 979da5f521df84f1f768f5853a131385d7af9d38..e2bd270cfc88fce789d9d62343c9b955c4275fb8 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

@@ -20,7 +20,7 @@ class ScrollState;

class ViewportScrollCallback : public ScrollStateCallback {

public:

- ViewportScrollCallback(Document&, FrameHost&);

+ ViewportScrollCallback(Document&);

~ViewportScrollCallback();

void handleEvent(ScrollState*) override;

@@ -32,8 +32,6 @@ private:

ScrollableArea* getRootFrameViewport() const;

WeakMember<Document> m_document;

- WeakMember<FrameHost> m_frameHost;

};

} // namespace blink