Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1895323002: Viewport apply scroll should be on the document element not scrollingElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
1151 1151
1152 void setHoverNode(Node*); 1152 void setHoverNode(Node*);
1153 1153
1154 using EventFactorySet = HashSet<OwnPtr<EventFactoryBase>>; 1154 using EventFactorySet = HashSet<OwnPtr<EventFactoryBase>>;
1155 static EventFactorySet& eventFactories(); 1155 static EventFactorySet& eventFactories();
1156 1156
1157 void setNthIndexCache(NthIndexCache* nthIndexCache) { DCHECK(!m_nthIndexCach e || !nthIndexCache); m_nthIndexCache = nthIndexCache; } 1157 void setNthIndexCache(NthIndexCache* nthIndexCache) { DCHECK(!m_nthIndexCach e || !nthIndexCache); m_nthIndexCache = nthIndexCache; }
1158 1158
1159 const OriginAccessEntry& accessEntryFromURL(); 1159 const OriginAccessEntry& accessEntryFromURL();
1160 1160
1161 // Installs the viewport scrolling callback (the "applyScroll" in Scroll
1162 // Customization lingo) on the root scrollingElement. This callback is
1163 // responsible for viewport related scroll actions like top controls
1164 // movement and overscroll glow as well as actually scrolling the root
1165 // viewport.
1166 void updateViewportApplyScroll();
1167
1168 DocumentLifecycle m_lifecycle; 1161 DocumentLifecycle m_lifecycle;
1169 1162
1170 bool m_hasNodesWithPlaceholderStyle; 1163 bool m_hasNodesWithPlaceholderStyle;
1171 bool m_evaluateMediaQueriesOnStyleRecalc; 1164 bool m_evaluateMediaQueriesOnStyleRecalc;
1172 1165
1173 // If we do ignore the pending stylesheet count, then we need to add a boole an 1166 // If we do ignore the pending stylesheet count, then we need to add a boole an
1174 // to track that this happened so that we can do a full repaint when the sty lesheets 1167 // to track that this happened so that we can do a full repaint when the sty lesheets
1175 // do eventually load. 1168 // do eventually load.
1176 PendingSheetLayout m_pendingSheetLayout; 1169 PendingSheetLayout m_pendingSheetLayout;
1177 1170
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 String m_rawTitle; 1257 String m_rawTitle;
1265 Member<Element> m_titleElement; 1258 Member<Element> m_titleElement;
1266 1259
1267 Member<AXObjectCache> m_axObjectCache; 1260 Member<AXObjectCache> m_axObjectCache;
1268 Member<DocumentMarkerController> m_markers; 1261 Member<DocumentMarkerController> m_markers;
1269 1262
1270 Timer<Document> m_updateFocusAppearanceTimer; 1263 Timer<Document> m_updateFocusAppearanceTimer;
1271 1264
1272 Member<Element> m_cssTarget; 1265 Member<Element> m_cssTarget;
1273 1266
1274 // Not a WeakMember since we want to keep the scrollingElement around until
1275 // we move its ApplyScroll onto the new scrollingElement.
1276 Member<Element> m_oldScrollingElement;
1277
1278 LoadEventProgress m_loadEventProgress; 1267 LoadEventProgress m_loadEventProgress;
1279 1268
1280 double m_startTime; 1269 double m_startTime;
1281 1270
1282 Member<ScriptRunner> m_scriptRunner; 1271 Member<ScriptRunner> m_scriptRunner;
1283 1272
1284 HeapVector<Member<HTMLScriptElement>> m_currentScriptStack; 1273 HeapVector<Member<HTMLScriptElement>> m_currentScriptStack;
1285 1274
1286 OwnPtr<TransformSource> m_transformSource; 1275 OwnPtr<TransformSource> m_transformSource;
1287 1276
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1442 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true); 1431 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
1443 1432
1444 } // namespace blink 1433 } // namespace blink
1445 1434
1446 #ifndef NDEBUG 1435 #ifndef NDEBUG
1447 // Outside the WebCore namespace for ease of invocation from gdb. 1436 // Outside the WebCore namespace for ease of invocation from gdb.
1448 CORE_EXPORT void showLiveDocumentInstances(); 1437 CORE_EXPORT void showLiveDocumentInstances();
1449 #endif 1438 #endif
1450 1439
1451 #endif // Document_h 1440 #endif // Document_h
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698