Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 #include "wtf/CurrentTime.h" 102 #include "wtf/CurrentTime.h"
103 #include "wtf/StdLibExtras.h" 103 #include "wtf/StdLibExtras.h"
104 #include "wtf/TemporaryChange.h" 104 #include "wtf/TemporaryChange.h"
105 105
106 namespace blink { 106 namespace blink {
107 107
108 namespace { 108 namespace {
109 109
110 bool hasTouchHandlers(const EventHandlerRegistry& registry) 110 bool hasTouchHandlers(const EventHandlerRegistry& registry)
111 { 111 {
112 return registry.hasEventHandlers(EventHandlerRegistry::TouchEventBlocking) 112 return registry.hasEventHandlers(EventHandlerRegistry::TouchStartOrMoveEvent Blocking)
113 || registry.hasEventHandlers(EventHandlerRegistry::TouchEventPassive); 113 || registry.hasEventHandlers(EventHandlerRegistry::TouchStartOrMoveEvent Passive)
114 || registry.hasEventHandlers(EventHandlerRegistry::TouchEndOrCancelEvent Blocking)
115 || registry.hasEventHandlers(EventHandlerRegistry::TouchEndOrCancelEvent Passive);
114 } 116 }
115 117
116 const AtomicString& touchEventNameForTouchPointState(PlatformTouchPoint::TouchSt ate state) 118 const AtomicString& touchEventNameForTouchPointState(PlatformTouchPoint::TouchSt ate state)
117 { 119 {
118 switch (state) { 120 switch (state) {
119 case PlatformTouchPoint::TouchReleased: 121 case PlatformTouchPoint::TouchReleased:
120 return EventTypeNames::touchend; 122 return EventTypeNames::touchend;
121 case PlatformTouchPoint::TouchCancelled: 123 case PlatformTouchPoint::TouchCancelled:
122 return EventTypeNames::touchcancel; 124 return EventTypeNames::touchcancel;
123 case PlatformTouchPoint::TouchPressed: 125 case PlatformTouchPoint::TouchPressed:
(...skipping 3889 matching lines...) Expand 10 before | Expand all | Expand 10 after
4013 PlatformEvent::Modifiers EventHandler::accessKeyModifiers() 4015 PlatformEvent::Modifiers EventHandler::accessKeyModifiers()
4014 { 4016 {
4015 #if OS(MACOSX) 4017 #if OS(MACOSX)
4016 return static_cast<PlatformEvent::Modifiers>(PlatformEvent::CtrlKey | Platfo rmEvent::AltKey); 4018 return static_cast<PlatformEvent::Modifiers>(PlatformEvent::CtrlKey | Platfo rmEvent::AltKey);
4017 #else 4019 #else
4018 return PlatformEvent::AltKey; 4020 return PlatformEvent::AltKey;
4019 #endif 4021 #endif
4020 } 4022 }
4021 4023
4022 } // namespace blink 4024 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698