Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 ASSERT(m_inputTypeView); 429 ASSERT(m_inputTypeView);
430 430
431 bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler(); 431 bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler();
432 if (hasTouchEventHandler == !!m_hasTouchEventHandler) 432 if (hasTouchEventHandler == !!m_hasTouchEventHandler)
433 return; 433 return;
434 // If the Document is being or has been stopped, don't register any handlers . 434 // If the Document is being or has been stopped, don't register any handlers .
435 if (document().frameHost() && document().lifecycle().state() < DocumentLifec ycle::Stopping) { 435 if (document().frameHost() && document().lifecycle().state() < DocumentLifec ycle::Stopping) {
436 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry(); 436 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry();
437 // TODO(dtapuska): Make this passive touch listener see crbug.com/584438 437 // TODO(dtapuska): Make this passive touch listener see crbug.com/584438
438 if (hasTouchEventHandler) 438 if (hasTouchEventHandler)
439 registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEventB locking); 439 registry.didAddEventHandler(*this, EventHandlerRegistry::TouchStartO rMoveEventBlocking);
440 else 440 else
441 registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEve ntBlocking); 441 registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchSta rtOrMoveEventBlocking);
442 m_hasTouchEventHandler = hasTouchEventHandler; 442 m_hasTouchEventHandler = hasTouchEventHandler;
443 } 443 }
444 } 444 }
445 445
446 void HTMLInputElement::initializeTypeInParsing() 446 void HTMLInputElement::initializeTypeInParsing()
447 { 447 {
448 ASSERT(m_parsingInProgress); 448 ASSERT(m_parsingInProgress);
449 ASSERT(!m_inputType); 449 ASSERT(!m_inputType);
450 ASSERT(!m_inputTypeView); 450 ASSERT(!m_inputTypeView);
451 451
(...skipping 1497 matching lines...) Expand 10 before | Expand all | Expand 10 after
1949 void HTMLInputElement::ensurePrimaryContent() 1949 void HTMLInputElement::ensurePrimaryContent()
1950 { 1950 {
1951 m_inputTypeView->ensurePrimaryContent(); 1951 m_inputTypeView->ensurePrimaryContent();
1952 } 1952 }
1953 1953
1954 bool HTMLInputElement::hasFallbackContent() const 1954 bool HTMLInputElement::hasFallbackContent() const
1955 { 1955 {
1956 return m_inputTypeView->hasFallbackContent(); 1956 return m_inputTypeView->hasFallbackContent();
1957 } 1957 }
1958 } // namespace blink 1958 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698