third_party/WebKit/LayoutTests/plugins/re-request-touch-events-crash.html - Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/re-request-touch-events-crash.html

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/touch-target-removed-crash.html ('k') | third_party/WebKit/LayoutTests/plugins/re-request-touch-events-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../resources/js-test.js"></script>	3 <script src="../resources/js-test.js"></script>

4 </head>	4 </head>

5	5

6 <body>	6 <body>

7 <embed id="touch_plugin" type="application/x-webkit-test-webplugin" accepts-touc h="raw" re-request-touch="true"></embed>	7 <embed id="touch_plugin" type="application/x-webkit-test-webplugin" accepts-touc h="raw" re-request-touch="true"></embed>

8 <p id="description"></p>	8 <p id="description"></p>

9 <script>	9 <script>

10 description("This test ensures that we don't imbalance the touch event handler c ount if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.");	10 description("This test ensures that we don't imbalance the touch event handler c ount if a plugin requests touch events more than once. The test passes if there are no touch event listeners after the plugin is removed, and there is no crash. Must be run in DRT.");

11	11

12 if (window.testRunner) {	12 if (window.testRunner) {

13 testRunner.dumpAsText();	13 testRunner.dumpAsText();

14	14

15 // Force the plugin to initialize	15 // Force the plugin to initialize

16 touch_plugin.offsetTop;	16 touch_plugin.offsetTop;

17	17

18 shouldBe("window.internals.touchEventHandlerCount(document)", "1")	18 shouldBe("window.internals.touchStartOrMoveEventHandlerCount(document)", "1" )

19 touch_plugin.parentNode.removeChild(touch_plugin);	19 touch_plugin.parentNode.removeChild(touch_plugin);

20 shouldBe("window.internals.touchEventHandlerCount(document)", "0")	20 shouldBe("window.internals.touchStartOrMoveEventHandlerCount(document)", "0" )

21 }	21 }

22	22

23 </script>	23 </script>

24 </body>	24 </body>

OLD	NEW