Chromium Code Reviews| Index: third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl |
| diff --git a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl |
| index df2f2f6d0bfe665487c85e3556dbc5ebf12c4c1c..7a8a6ebeec21037eab9ade840ed7a2926f79b626 100644 |
| --- a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl |
| +++ b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl |
| @@ -16,25 +16,24 @@ namespace blink { |
| class InternalRuntimeFlags : public GarbageCollected<InternalRuntimeFlags>, public ScriptWrappable { |
| DEFINE_WRAPPERTYPEINFO(); |
| public: |
| - static InternalRuntimeFlags* create() |
| - { |
| - return new InternalRuntimeFlags; |
| - } |
| - |
| -{# |
| - Setting after startup does not work for most runtime flags, but we |
| - could add an option to print setters for ones which do: |
| - void set{{feature.name}}Enabled(bool isEnabled) { RuntimeEnabledFeatures::set{{feature.name}}Enabled(isEnabled); } |
| - If we do that, we also need to respect Internals::resetToConsistentState. |
| -#} |
| + static InternalRuntimeFlags* create(); |
| + |
| + {% for feature in standard_features if feature.settable_from_internals %} |
| + void set{{feature.name}}Enabled(bool isEnabled); |
| + {% endfor %} |
| + |
| {% for feature in standard_features %} |
| - bool {{feature.first_lowered_name}}Enabled() { return RuntimeEnabledFeatures::{{feature.first_lowered_name}}Enabled(); } |
| + bool {{feature.first_lowered_name}}Enabled(); |
| {% endfor %} |
| DEFINE_INLINE_TRACE() { } |
| private: |
| - InternalRuntimeFlags() { } |
| + InternalRuntimeFlags(); |
| + |
| + {% for feature in standard_features %} |
| + bool m_{{feature.first_lowered_name}}; |
|
jbroman
2016/04/28 14:24:39
Why do these members exist? You don't seem to actu
ymalik
2016/04/28 15:05:06
You're right they're not needed. I had them here b
|
| + {% endfor %} |
| }; |
| } // namespace blink |