Test fragment scrolling and history restoration interaction w/ scroll anchoring.

third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

Index: third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
index df2f2f6d0bfe665487c85e3556dbc5ebf12c4c1c..5950755ef6ddb4ed0edfe3bd1b190474d7c60f3d 100644
--- a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
@@ -16,25 +16,26 @@ namespace blink {
 class InternalRuntimeFlags : public GarbageCollected<InternalRuntimeFlags>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
-    static InternalRuntimeFlags* create()
-    {
-        return new InternalRuntimeFlags;
-    }
-
-{#
-    Setting after startup does not work for most runtime flags, but we
-    could add an option to print setters for ones which do:
-    void set{{feature.name}}Enabled(bool isEnabled) { RuntimeEnabledFeatures::set{{feature.name}}Enabled(isEnabled); }
-    If we do that, we also need to respect Internals::resetToConsistentState.
-#}
+    static InternalRuntimeFlags* create();
+
+    {% for feature in standard_features %}
+    {% if feature.set_from_internals %}

[wkorman, 2016/04/26 19:01:18]

Rather than looping and checking feature.set_from_internals everywhere, we could
generate the subset of settable features in a separate list like
'settable_from_internals' in make_internal_runtime_flags.py and then just
iterate over that in all places needed. Could be easier to maintain?

[ymalik, 2016/04/26 20:17:39]

I think that would only be the case if we plan to add additional logic that
would conditionally set settable_from_internals on top of the value set in
RuntimeEnabledFeatures.in. I think otherwise, its probably okay to just check
for the option? I put it in one line to make it cleaner.

It also makes it less cleaner to conditionally set 'readonly' from
InternalRuntimeFlags.idl because we would have to do something like, 

if standard_feature and not in settabble_from_internals.

I don't feel strong either way. WDYT?

+    void set{{feature.name}}Enabled(bool isEnabled);
+    {% endif %}
+    {% endfor %}
+
     {% for feature in standard_features %}
-    bool {{feature.first_lowered_name}}Enabled() { return RuntimeEnabledFeatures::{{feature.first_lowered_name}}Enabled(); }
+    bool {{feature.first_lowered_name}}Enabled();
     {% endfor %}
 
     DEFINE_INLINE_TRACE() { }
 
 private:
-    InternalRuntimeFlags() { }
+    InternalRuntimeFlags();
+
+    {% for feature in standard_features %}
+    bool m_{{feature.first_lowered_name}};
+    {% endfor %}
 };
 
 } // namespace blink