third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl - Issue 1895293002: Test fragment scrolling and history restoration interaction w/ scroll anchoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

Issue 1895293002: Test fragment scrolling and history restoration interaction w/ scroll anchoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove .cpp.tmpl and other review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_runtime_features.py ('k') | third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.idl.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

index df2f2f6d0bfe665487c85e3556dbc5ebf12c4c1c..dc486ac5645a973990c2909039b173b7d781f65d 100644

--- a/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl

@@ -21,12 +21,12 @@ public:

return new InternalRuntimeFlags;

}

-{#

- Setting after startup does not work for most runtime flags, but we

- could add an option to print setters for ones which do:

+ // These are reset between layout tests from Internals::resetToConsistentState

+ // using RuntimeEnabledFeatures::Backup.

+ {% for feature in standard_features if feature.settable_from_internals %}

void set{{feature.name}}Enabled(bool isEnabled) { RuntimeEnabledFeatures::set{{feature.name}}Enabled(isEnabled); }

- If we do that, we also need to respect Internals::resetToConsistentState.

-#}

+ {% endfor %}

{% for feature in standard_features %}

bool {{feature.first_lowered_name}}Enabled() { return RuntimeEnabledFeatures::{{feature.first_lowered_name}}Enabled(); }

{% endfor %}